Skip to content

chore: stop building packages during install - #180

Closed
lilienblum wants to merge 4 commits into
mainfrom
lilienblum/remove-install-build-hooks
Closed

chore: stop building packages during install#180
lilienblum wants to merge 4 commits into
mainfrom
lilienblum/remove-install-build-hooks

Conversation

@lilienblum

Copy link
Copy Markdown
Contributor

Summary

  • remove the prepare build hook from the core, commands, bindings, and SDK packages
  • keep package compilation behind the existing explicit build commands

Why

A workspace pnpm install currently compiles all four packages as a lifecycle side effect. Bootstrap only needs dependencies installed, so that work is unnecessary and makes setup appear stuck.

The stable and dev npm release workflows already run pnpm build before publishing or packing. A prepack replacement would keep compilation implicit and duplicate those release build steps.

Validation

  • fresh and repeated pnpm install --frozen-lockfile complete without invoking the package builds
  • explicit builds succeed for core, commands, bindings, and SDK
  • package-layout fixture passes all 28 packed-artifact and consumer checks
  • Biome passes for the changed manifests

@lilienblum lilienblum added the refactor Behavior-preserving code reorganization label Jul 23, 2026
@lilienblum
lilienblum requested a review from alongubkin July 23, 2026 06:55
@lilienblum
lilienblum marked this pull request as ready for review July 23, 2026 06:56
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown

Greptile Summary

The PR removes install-time package compilation and explicitly builds required artifacts before tests and release smoke checks.

  • Removes prepare build hooks from core, commands, bindings, and SDK packages.
  • Makes Turbo tests depend on package builds.
  • Builds the native bindings addon before bindings tests.
  • Builds core and bindings packages before the release addon smoke test.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains in the fixes for the previously reported clean-checkout test failures.

Important Files Changed

Filename Overview
turbo.json Adds package and dependency builds before tests, resolving the clean-checkout missing-distribution-artifact failure.
packages/bindings/turbo.json Preserves inherited test build dependencies and adds native-addon compilation before bindings tests.
.github/workflows/release.yml Explicitly builds core and bindings artifacts before the staged-addon smoke test.
packages/core/package.json Removes install-time compilation while retaining the explicit build command.
packages/commands/package.json Removes install-time compilation while retaining the explicit build command.
packages/bindings/package.json Removes install-time TypeScript compilation while retaining explicit wrapper and addon build commands.
packages/sdk/package.json Removes install-time compilation while retaining the explicit build command.

Reviews (3): Last reviewed commit: "test: build bindings addon before tests" | Re-trigger Greptile

Comment thread packages/core/package.json
Comment thread turbo.json
@lilienblum

Copy link
Copy Markdown
Contributor Author

Superseded by #236, recreated from the same tested head on an ALIEN-374-compliant branch so CI can run.

@lilienblum lilienblum closed this Jul 27, 2026
@lilienblum
lilienblum deleted the lilienblum/remove-install-build-hooks branch July 28, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Behavior-preserving code reorganization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant