chore: stop building packages during install - #180
Closed
lilienblum wants to merge 4 commits into
Closed
Conversation
Greptile SummaryThe PR removes install-time package compilation and explicitly builds required artifacts before tests and release smoke checks.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains in the fixes for the previously reported clean-checkout test failures.
|
| Filename | Overview |
|---|---|
| turbo.json | Adds package and dependency builds before tests, resolving the clean-checkout missing-distribution-artifact failure. |
| packages/bindings/turbo.json | Preserves inherited test build dependencies and adds native-addon compilation before bindings tests. |
| .github/workflows/release.yml | Explicitly builds core and bindings artifacts before the staged-addon smoke test. |
| packages/core/package.json | Removes install-time compilation while retaining the explicit build command. |
| packages/commands/package.json | Removes install-time compilation while retaining the explicit build command. |
| packages/bindings/package.json | Removes install-time TypeScript compilation while retaining explicit wrapper and addon build commands. |
| packages/sdk/package.json | Removes install-time compilation while retaining the explicit build command. |
Reviews (3): Last reviewed commit: "test: build bindings addon before tests" | Re-trigger Greptile
Contributor
Author
|
Superseded by #236, recreated from the same tested head on an ALIEN-374-compliant branch so CI can run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preparebuild hook from the core, commands, bindings, and SDK packagesbuildcommandsWhy
A workspace
pnpm installcurrently compiles all four packages as a lifecycle side effect. Bootstrap only needs dependencies installed, so that work is unnecessary and makes setup appear stuck.The stable and dev npm release workflows already run
pnpm buildbefore publishing or packing. Aprepackreplacement would keep compilation implicit and duplicate those release build steps.Validation
pnpm install --frozen-lockfilecomplete without invoking the package builds