fix: Better / more / more useful example scripts - #13
Open
VedantMadane wants to merge 1 commit into
Open
Conversation
- examples/basic-usage.js - README.md Fixes airbreather#9 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
airbreather
requested changes
Aug 25, 2026
airbreather
left a comment
airbreather
left a comment
Owner
There was a problem hiding this comment.
I think for a sample script to be useful, it needs to show some usage of the Acore APIs that justify embedding Node.js into AzerothCore in the first place.
To that end, I think the things that I've already added to examples/ do the job - TBH, I probably should have closed #9 after putting those there, since TypeScript is practically a requirement for this (because of how easy it is to just randomly segfault or hit horrible errors if you don't use everything exactly right).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Better / more / more useful example scripts
Changes
Fixes #9