Repository navigation
test(python): expose profiler and Replay import failures - #17594
Conversation
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Require test imports and configuration components/src/dynamo/profiler/tests/*, components/src/dynamo/replay/tests/e2e/test_unified_cli_dynamo.py |
Profiler and replay tests now allow import failures to surface instead of skipping the module. The profiler integration test proceeds without checking whether its YAML configuration file exists. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Merge Risk: 
Minimal · up to 15015
-
This change only affects test modules. Missing profiler or replay dependencies now fail test collection rather than being silently skipped. The supported Planner test environment provides those dependencies, so no merge-blocking risk is identified.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title "test(python): expose profiler and Replay import failures" matches the main change. The PR replaces module-wide ImportError skips in the Profiler and Replay test modules with direct imports, so import failures now surface during collection. The title names the Profiler and Replay areas and the behavior change. It omits the mocker config change, which is a minor detail.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files.
Full details: Description check
-
Explanation
The pull request description includes all required sections: Overview, Key Changes, Validation, Issues and Ongoing Work, and the checklist. It explains that the change is partial work for
#13545and does not incorrectly claim to close the umbrella issue.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
✅ Dynamo PR CI passed — run 40878175273 (attempt 1) on
|
Overview
These tests used
try/except ImportErrorto allow collection while Profiler/AISimulate dependencies were missing or being refactored. The Planner test environment now provides those dependencies consistently, so this fallback is no longer needed.Key Changes
Use direct imports in three Profiler test modules and the Replay CLI suite. Broken imports and a missing required mocker fixture now fail instead of skipping tests.
Validation
107 tests passed, zero skipped. Missing-SDK probes confirm collection errors.
Issues and Ongoing Work
Part of #13545; refs DGH-1426. Extracted from #17588.
Pull Request Checklist
/pr-checklistskill.