Skip to content

test(python): expose profiler and Replay import failures - #17594

Merged
sttts merged 1 commit into
mainfrom
sttts-dgh-1426-test-import-failures
Oct 29, 2026
Merged

sttts merged 1 commit into
mainfrom
sttts-dgh-1426-test-import-failures

Conversation

@sttts

@sttts sttts commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Overview

These tests used try/except ImportError to allow collection while Profiler/AISimulate dependencies were missing or being refactored. The Planner test environment now provides those dependencies consistently, so this fallback is no longer needed.

Key Changes

Use direct imports in three Profiler test modules and the Replay CLI suite. Broken imports and a missing required mocker fixture now fail instead of skipping tests.

Validation

107 tests passed, zero skipped. Missing-SDK probes confirm collection errors.

Issues and Ongoing Work

Part of #13545; refs DGH-1426. Extracted from #17588.

Pull Request Checklist
  • I used Dynamo's /pr-checklist skill.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 00d3deb and 1501530.

Files selected for processing: 4
  • components/src/dynamo/profiler/tests/integration/test_profile_sla_dgdr.py
  • components/src/dynamo/profiler/tests/unit/test_dgd_generation_ais.py
  • components/src/dynamo/profiler/tests/unit/test_dgd_materialization.py
  • components/src/dynamo/replay/tests/e2e/test_unified_cli_dynamo.py
Files with no reviewable changes: 1
  • components/src/dynamo/replay/tests/e2e/test_unified_cli_dynamo.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

Test modules in the profiler and replay components no longer skip when required imports are unavailable. The profiler integration test also no longer skips when its configured YAML file is absent.

Changes

Test prerequisite enforcement

Layer / File(s) Summary
Require test imports and configuration
components/src/dynamo/profiler/tests/*, components/src/dynamo/replay/tests/e2e/test_unified_cli_dynamo.py
Profiler and replay tests now allow import failures to surface instead of skipping the module. The profiler integration test proceeds without checking whether its YAML configuration file exists.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: Minimal · up to 15015

This change only affects test modules. Missing profiler or replay dependencies now fail test collection rather than being silently skipped. The supported Planner test environment provides those dependencies, so no merge-blocking risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "test(python): expose profiler and Replay import failures" matches the main change. The PR replaces module-wide ImportError skips in the Profiler and Replay test modules with direct imports,…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The pull request description includes all required sections: Overview, Key Changes, Validation, Issues and Ongoing Work, and the checklist. It explains that the change is partial work for #13545 and d…
Full details: Title check

Explanation

The title "test(python): expose profiler and Replay import failures" matches the main change. The PR replaces module-wide ImportError skips in the Profiler and Replay test modules with direct imports, so import failures now surface during collection. The title names the Profiler and Replay areas and the behavior change. It omits the mocker config change, which is a minor detail.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files.

Full details: Description check

Explanation

The pull request description includes all required sections: Overview, Key Changes, Validation, Issues and Ongoing Work, and the checklist. It explains that the change is partial work for #13545 and does not incorrectly claim to close the umbrella issue.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration

Copy link
Copy Markdown
Contributor

✅ Dynamo PR CI passed — run 40878175273 (attempt 1) on 1501530b20

Gate checks: ✅ backend-status-check · ✅ deploy-status-check · ✅ dynamo-status-check

Posted automatically by Devin for run 40878175273. Updated on every full-CI run of this PR.

@sttts
sttts merged commit c88bd2e into main Oct 29, 2026
143 checks passed
@sttts
sttts deleted the sttts-dgh-1426-test-import-failures branch October 29, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants