Repository navigation
Keep split views together when tabs move to another profile - #17
Merged
Merged
Conversation
This was referenced Nov 5, 2026
afrojun
force-pushed
the
feature/action-menu
branch
from
November 5, 2026 02:41
afa5b47 to
b78cece
Compare
Moving either half of a split view from the tab strip now moves both, and a group move carries the splits inside it. The move sends ProfileBar the split views as pairs of neighbouring positions in its URL list. ProfileBar checks them and passes them on through the profile relay and the group handoff, and the destination's copy of the extension splits those tabs again with chrome.tabs.createSplit (Chrome 155 and later). Older versions of either end ignore the new field and still move the tabs, without the split. tab-splits.js holds both ends of the extension's side, and the page tests now load each page's scripts in the order its HTML lists them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
afrojun
force-pushed
the
feature/split-moves
branch
from
November 5, 2026 02:45
9c3fe90 to
b30c436
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sequenceDiagram participant S as Source extension participant H as ProfileBar helper participant D as Destination extension S->>H: openURLs / openGroup { urls, splits: [[1, 2]] } H->>H: TabSplits.parse (neighbouring pairs, in range, each tab once) H->>D: relay "open" or claimGroup { urls, splits } D->>D: create tabs, then TabSplits.rebuild → chrome.tabs.createSplitextension/tab-splits.jsholds both ends of the extension's side and is shared by the service worker and the group receiver.Both ends of the protocol change in this PR, as
AGENTS.mdrequires. Older versions on either side ignoresplitsand still move the tabs, without the split. Stacked on #16.Evidence
After: 75 extension tests and
./test.shpass. Breaking each part (source pairs, partner expansion, arrival rebuild, group rebuild) in a scratch copy fails a test.moveToProfile):[[Int.max, 0]]overflowed before the range check and would crash the helper. Fixed by checking the range first, withInt.maxand-1regression cases.Merge Danger
Door: two-way
Blast Radius: native protocol
Release ProfileBar 1.6.0 before the extension update that sends splits. In the other order nothing breaks, but splits aren't rebuilt until the app catches up.
🤖 Generated with Claude Code