Skip to content

Offer the tab moves from the toolbar icon's menu - #16

Merged
afrojun merged 1 commit into
mainfrom
feature/action-menu
Nov 5, 2026
Merged

afrojun merged 1 commit into
mainfrom
feature/action-menu

Conversation

@afrojun

@afrojun afrojun commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Summary

Toolbar icon right-click menu (acts on the active tab)
├── Move tab to profile ▸       destinations greyed out on non-web pages, Refresh always available
├── Always open this site in ▸  greyed out on non-web pages
└── Move group to profile ▸     shown only when the active tab is in a group
 buildPageMenu / buildAlwaysOpenMenu
-  contexts: ["page"]
+  contexts: ["page", "action"]
+buildGroupActionMenu              # action-only, ids action-group:profile:<dir>
-updateGroupMenu
+updateTabMenus → showTabActions   # tab-strip group items + toolbar items, follows tabs.onActivated / onUpdated

The manifest gains an empty "action": {}, which Chrome needs to show action-context items. It adds no permission and no install prompt. Stacked on #15.

Evidence

  • Before: right-clicking the toolbar icon showed only Chrome's own items.
    After: 71 extension tests pass, including:
    • the toolbar menu offers the moves that suit the active tab
    • the toolbar menu keeps setup reachable on pages that cannot move
    • moving a group from the toolbar menu moves the active tab's group
  • Live: on chrome://extensions the move items are greyed out and the group item is hidden. On a grouped tab, all three are active and Move group to profile lists the other profiles.
  • Pre-push review finding: greying out the whole parent hid Set up ProfileBar… and Refresh profiles. Fixed by greying out only the destinations, with a regression test.

Merge Danger

Door: two-way

Blast Radius: menus

Chrome adds a greyed-out "Inspect pop-up" item for unpacked builds with an action. Store builds don't show it.

🤖 Generated with Claude Code

@afrojun
afrojun deleted the branch fix/reopened-tabs-stay November 5, 2026 02:40
@afrojun afrojun closed this Nov 5, 2026
@afrojun afrojun reopened this Nov 5, 2026
@afrojun
afrojun changed the base branch from fix/reopened-tabs-stay to main November 5, 2026 02:41
Right-clicking the extension's toolbar icon now shows Move tab to profile and
Always open this site in for the active tab, and Move group to profile when
that tab is in a group. The items grey out on pages that cannot move and
follow the active tab as it changes. The manifest gains an empty action,
which Chrome needs to show these items and which adds no permission.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@afrojun
afrojun force-pushed the feature/action-menu branch from afa5b47 to b78cece Compare November 5, 2026 02:41
@afrojun
afrojun merged commit 7e00ba4 into main Nov 5, 2026
2 checks passed
@afrojun
afrojun deleted the feature/action-menu branch November 5, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant