Repository navigation
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
Owner
Author
|
Closing in favour of a three-way Markdown styling setting (off / minimal / full), coming in the next PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A returning writer reported in #28 that the post title is painfully bright in a dark iTerm2 theme. Settings now has a Bold title switch. Turning it off shows the first
#heading in plain terminal text; later headings and explicit**bold**stay formatted. Existing vaults keep the current bold appearance until the writer changes this setting. The Markdown and vault data are unchanged.The separate Typinator expansion problem from #28 is still being investigated.
Try it
gh pr checkout 31 && cargo runFrom the post list, press
sfor Settings. Select Bold title with the arrow keys or mouse and press Enter or click to switch it off. Open a post to see its title without bold.Verification
cargo fmt --check,cargo test(151 passed), andcargo clippy --all-targetspassed. I tested the setting and editor in the real app with an isolatedwritui-devvault, then checked the site build at desktop and phone sizes. The demo remains accurate because the default title style is unchanged.