Repository navigation
fix(api): preserve provider reasoning across tool calls #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
082b50d
0f23caf
8c366e7
6ab56df
6ea0b42
6e471dc
5be91d1
562a8f8
e7f4ac0
4088b89
3cdc4f6
240de8b
54fca66
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -984,7 +984,9 @@ | |
| conversationId?: string, // Optional conversation ID to track cache points across messages | ||
| ): { system: SystemContentBlock[]; messages: Message[] } { | ||
| // First convert messages using shared converter for proper image handling | ||
| const convertedMessages = sharedConverter(anthropicMessages as Anthropic.Messages.MessageParam[]) | ||
| const convertedMessages = sharedConverter(anthropicMessages as Anthropic.Messages.MessageParam[], { | ||
| preserveReasoning: modelInfo?.preserveReasoning === true, | ||
|
Check warning on line 988 in src/api/providers/bedrock.ts
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Stop reasoning replay at a new user message. When history contains signed MiniMax thinking followed by a new user text message, this option still replays the earlier thinking. The test’s 🧰 Tools🪛 GitHub Check: mutation-diff[warning] 986-986: Mutation test advisory 🤖 Prompt for AI Agents |
||
| }) | ||
|
|
||
| // If prompt caching is disabled, return the converted messages directly | ||
| if (!usePromptCache) { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.