Repository navigation
feat(nodes): show the configured stream transport - #524
Merged
Merged
Conversation
Display transport information reported by the backend while preserving protocol filters and compatibility with older responses. Keep XHTTP share links intact through node creation and editing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nodes show only the proxy protocol, so users cannot identify a configured XHTTP transport even when the backend reports it.
How I fixed it
Display the optional configured transport beside the protocol, preserving the existing display for absent or null fields and the existing protocol filter. Keep unfamiliar transport names readable. Add three-language help, an XHTTP demo node and tests that preserve raw
xhttp/splithttplinks through create and edit. Net lines: application code +9, generated types +8, unit tests +33, e2e +33, CSS 0; locale replacements have zero net lines. The owner approved the local preview.Verified
pnpm checkpasses on the rebased branch. Coverage, build and size checks passed before the rebase, whose only base change is release tooling. Chromium completed 1,818 cases with 14 skipped; two added cases initially failed because the mock source needed a refresh, and the three affected cases passed after the correction. WebKit passed 319 with 18 skipped.check:genverifies the updated contract, and the implementation had an independent cold review. CI reruns the full gates on this branch. Backend transport reporting is a separate honk change; older backends retain the existing display.Submitted and answered for by (Human responsible, GitHub username): Zakkaus
main.type(scope): subjectand a short English body.CONTRIBUTING.md; the Verified section records the commands, results and any checks I could not complete.en.jsonand in every complete language's catalogue when I changed interface text.pnpm gen:apiandpnpm check:genwhen I changed the API contract.