Repository navigation
fix(release): bundle honk with the matching doona version - #523
Merged
Merged
Conversation
Publish the UI before building honk, then verify its embedded UI pins before attaching the bundle to the same release. Keep source provenance and preserve standalone assets during repairs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Each release bundled honk before the new UI was public, so honk could only embed an older doona version.
How I fixed it
Publish standalone assets first, then attach a verified honk build to the same release. The fetch tool requires explicit honk and doona tags and checks honk's UI version, revision and program digest against the published UI. It includes both source archives and writes the provenance note only after completion. The documented repair preserves existing UI and package bytes. Net changes: production +21, unit tests +81, e2e 0, CSS 0.
Verified
Local check passed 3,631 tests; coverage, build and size passed. After the note-write fix, all 68 targeted release tests passed. Removing the version guard made the stale-version regression fail; restoring it passed. Independent review's partial-note finding is fixed and covered. Chromium projects passed 1,819 tests. The official Playwright image passed 319 WebKit tests (18 skipped); the initial host run could not launch WebKit because its libraries were unavailable. Live honk attachment replacement awaits the matching debug build.
Submitted and answered for by: @Zakkaus