Repository navigation
fix(rules): place template help beside its title - #517
Merged
Merged
Conversation
Lay out radio titles and contextual help together so longer descriptions cannot push the info button away from its title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long descriptions push rule template info buttons away from their titles.
How I fixed it
Place contextual help beside the radio title while retaining the description inside the clickable label. Product net +42 lines (TSX +12, CSS +30); unit tests +13, e2e +65.
Verified
pnpm checkpassed 3,612 tests;pnpm buildandpnpm check:sizepassed. The rules-templates, inline-align and rules Chromium specs passed 46 tests. English and Traditional Chinese previews passed at 390/1280 widths in Glass and Rose Pine; the previous build failed the title-gap regression check. Zakkaus approved the local preview. Full cross-browser CI gates will run on this PR.Submitted and answered for by (Human responsible, GitHub username): @Zakkaus