Repository navigation
feat(policies): collapse region choices by default - #516
Merged
Merged
Conversation
Keep the group editor compact by placing region choices in the existing disclosure. Preserve selected tags and the checklist accessible name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The group editor opens the full region checklist, pushing the remaining settings below the fold even when the selected region tags already describe the group.
How I fixed it
Reuse the existing flush Disclosure to collapse region choices by default in new and existing groups. Keep selected tags visible and preserve the checklist's accessible name with an optional hidden label. Selection, removal, undo and saved filters are unchanged. Net additions: source 5, unit tests 0, e2e 42, CSS 0. Zakkaus reviewed the local preview and approved merging.
Verified
pnpm checkpassed, including 3,611 unit tests.pnpm buildandpnpm check:sizepassed. Five related Chromium specs passed all 62 tests, covering keyboard expansion, selected tags, removal, undo, saving and reopening. A negative control without the production change failed because the Regions disclosure was absent. Desktop and mobile previews were checked in English and Traditional Chinese with ordinary and Glass palettes. Full browser coverage runs in CI.