Skip to content

fix: restore stats after interpolation and Native 7cd7e cues - #109

Merged
ZHINFINITY merged 1 commit into
mainfrom
fix/stats-survive-interpolation
Oct 24, 2026
Merged

ZHINFINITY merged 1 commit into
mainfrom
fix/stats-survive-interpolation

Conversation

@ZHINFINITY

Copy link
Copy Markdown
Owner

Unmerged follow-up to #108.

  • Frame interpolation restart restores the current stats.lua page instead of wiping it
  • Off hides stats instead of toggling them back on after interpolation
  • Native Media3 subtitle cue collectors restored to 7cd7e09 wiring
  • Extra WebVTT parser (95f8008) stays reverted

Flow APK: https://github.com/ZHINFINITY/Mpv-infinity/actions/runs/40117660656

stats.lua starts hidden on a new MPV core, so toggling Off from the
persisted page re-enabled a vanished overlay. Track whether lua is
actually shown, restore pages 1-5 after a successful interpolation
restart, and leave Off as a no-op when already hidden.

Native Media3 cue collection matches 7cd7e: configured-flag getters and
subtitleCueText on the live engine. The extra VTT parser stays reverted.
@ZHINFINITY
ZHINFINITY merged commit 95b88f2 into main Oct 24, 2026
2 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T18:04:59.485649Z f6e2b4b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant