Skip to content

fix: restore stats after interpolation, hide lua on music - #110

Merged
ZHINFINITY merged 3 commits into
mainfrom
fix/stats-lua-display-page
Oct 24, 2026
Merged

ZHINFINITY merged 3 commits into
mainfrom
fix/stats-lua-display-page

Conversation

@ZHINFINITY

Copy link
Copy Markdown
Owner

Unmerged follow-up after #109.

  • Interpolation restore waits for file-loaded, then display-page-N only (no toggle invert)
  • Off never re-enables vanished stats.lua
  • Music / minimize: MPV SurfaceView and subtitle overlay GONE so lua does not paint on Now Playing
  • Video background resume keeps last position from 7cd7e09
  • Native extra VTT parser stays out

User confirmed music overlay is gone. Flow APK: https://github.com/ZHINFINITY/Mpv-infinity/actions/runs/40127565405

ZHINFINITY added 3 commits October 25, 2026 00:15
…ition

Interpolation recreate restores pages 1-5 with display-page-N only, so
page 1 no longer hides itself a moment later. Off never toggles hidden
lua. Capture time-pos before Surface teardown so any background duration
resumes from that point, including the 15-minute ColorOS rebuild from
7cd7e. Native extra VTT parser stays reverted.
MPVView now uses PlayerStatsLuaCommandPolicy.STARTUP_APPLIED_PROPERTY
instead of the raw user-data string. Keep the ChipOwner source check
aligned with that restore path.
Wait for file-loaded/playback time before sending display-page-N after
an interpolation core recreate, then re-apply once on vo-reconfig so
page 1 cannot vanish. Music and minimize hide MPV and the subtitle
overlay with GONE and toggle lua only if shown, without clearing the
saved video page.
@ZHINFINITY
ZHINFINITY merged commit 1435492 into main Oct 24, 2026
2 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T20:22:44.357286Z 2c6232e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

PlaybackSession.command("script-binding", "stats/display-page-$page")

P2 Badge Use the persistent binding when restoring stats pages

For startup, video resume, and interpolation restore, this sends stats/display-page-N, which MPV registers as a one-shot display; persistent display uses stats/display-page-N-toggle (MPV stats.lua). The policy still records VISIBLE_PROPERTY=yes, so the overlay disappears after its configured duration (4 seconds by default) while subsequent Off or music actions treat it as visible and can turn it back on instead of hiding it. Use the persistent page binding for saved pages and keep the visibility marker aligned with that state.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant