Skip to content

GH Actions: fix flagnames in "Coveralls finish" workflow #23513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrfnl wants to merge 1 commit into
base: 1222-fix-coverall-report---ci-configuration
Choose a base branch
from
+9 −1
Open

GH Actions: fix flagnames in "Coveralls finish" workflow #23513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/finish-coveralls.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,5 +105,5 @@ jobs:
COVERALLS_SERVICE_NUMBER: ${{ github.sha }} # Connect all builds together.
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
carryforward: "unit-php-7.4,unit-php-8.3,php-7.4-wp-6.8-ms,php-8.3-wp-latest,php-8.3-wp-latest-ms,package-analysis-report,package-browserslist-config,package-components,package-feature-flag,package-helpers,package-js,package-replacement-variable-editor,package-search-metadata-previews,package-social-metadata-forms,package-social-metadata-previews,package-yoastseo"
carryforward: "unit-php-7.4,unit-php-8.3,php-7.4-wp-6.8,php-7.4-wp-6.8-ms,php-8.3-wp-latest,php-8.3-wp-latest-ms,package-analysis-report,package-browserslist-config,package-components,package-dashboard-frontend,package-feature-flag,package-helpers,package-js,package-replacement-variable-editor,package-search-metadata-previews,package-social-metadata-forms,package-social-metadata-previews,package-ui-library,package-yoastseo"
parallel-finished: true
4 changes: 4 additions & 0 deletions .github/workflows/jstest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ jobs:
# As these packages are all unique, don't stop the workflow when the test run of one package fails.
fail-fast: false
matrix:
# IMPORTANT: when these are updated, make sure to also update the `carryforward` flag names
# in the `finish-coveralls.yml` workflow!
package:
- 'analysis-report'
- 'browserslist-config'
Expand Down Expand Up @@ -141,6 +143,8 @@ jobs:
# As these packages are all unique, don't stop the workflow when the test run of one package fails.
fail-fast: false
matrix:
# IMPORTANT: when these are updated, make sure to also update the `carryforward` flag names
# in the `finish-coveralls.yml` workflow!
include:
- package: 'yoastseo'
needs_premium_config: true
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ jobs:
coverage: [false]

# Run code coverage only on high/low PHP.
# IMPORTANT: when these are updated, make sure to also update the `carryforward` flag names
# in the `finish-coveralls.yml` workflow!
include:
- php_version: 7.4
coverage: true
Expand Down Expand Up @@ -141,6 +143,8 @@ jobs:

strategy:
matrix:
# IMPORTANT: when these are updated, make sure to also update the `carryforward` flag names
# in the `finish-coveralls.yml` workflow!
include:
- php_version: "7.4"
wp_version: "6.8"
Expand Down