GH Actions: fix flagnames in "Coveralls finish" workflow - #23513
Open
jrfnl wants to merge 1 commit into
Open
Conversation
The flag names in the `carryforward` key in the `finish-coveralls.yml` workflow were out of date and incomplete. Let's see if the changes in this commit improve things. I've also added a comment now to alert GH Action maintainers to update the flags in the `finish-coveralls.yml` workflow when they update test matrices. Hopefully this will help going forward.
jrfnl
added
yoast cs/qa
changelog: non-user-facing
Contributor
Author
|
Note: the "Security" build failure is unrelated to this PR. The underlying branch basically needs a rebase. |
Coverage Report for CI Build 0Warning No base build found for commit Coverage: 44.384%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
The flag names in the
carryforwardkey in thefinish-coveralls.ymlworkflow were out of date and incomplete.Let's see if the changes in this commit improve things.
I've also added a comment now to alert GH Action maintainers to update the flags in the
finish-coveralls.ymlworkflow when they update test matrices. Hopefully this will help going forward.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps: