Repository navigation
docs: fix CODEOWNERS onchain paths and document full check suite in CONTRIBUTING.md - #647
Merged
dzekojohn4 merged 1 commit intoSep 30, 2026
Conversation
…ONTRIBUTING.md - CODEOWNERS (issue UnityChainxx#520): replace the nonexistent onchain/src/ and onchain/tests/ paths with the real contract crates under onchain/contracts/, correct "Cairo" to "Rust / Soroban", and drop the leftover template placeholder comment. Every path in the file now exists in the repository. - CONTRIBUTING.md (issue UnityChainxx#524): add a "Backend E2E Tests" section (backend/test/, jest-e2e.json, make test-backend-e2e) and a "Running the full check suite" section documenting make ci, the onchain cargo deny audit, npm audit gates and the gitleaks secret scan, each marked required or advisory with links to the workflow files. Closes UnityChainxx#520 Closes UnityChainxx#524 Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@DanielCharis1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the two documentation issues assigned to @DanielCharis1. The two backend code issues (#534, #527) require schema/CSP design changes and are not included here — see "Remaining issues" below.
Changes
#520 — CODEOWNERS lists onchain paths that do not exist and calls the Rust contracts Cairo
/onchain/src/and/onchain/tests/paths with the real contract crates:/onchain/contracts/,stellar_hunts,stellar_hunts_nft,stellar_hunts_receiver,stellar_hunts_types.while read -r p _; do [ -e "${p#/}" ] || echo "missing: $p"; done < <(grep '^/' .github/CODEOWNERS)— no output).#524 — CONTRIBUTING.md documents no way to run the backend e2e suite or the security scans
backend/test/), the Jest config (backend/test/jest-e2e.json), the run commands (npm run test:e2e,make test-backend-e2e, single-spec filtering), and the Postgres/Redis requirement.make cias the one-command entry pointcargo fmt/cargo build/cargo test(required)cargo deny --locked check advisories licenses bans sources(required)npm audit --audit-level=critical(required) vs--audit-level=high(advisory).github/workflows/build.yml/.github/workflows/security.yml) named, and SECURITY.md is linked for the security-gate status.Remaining issues (not in this PR)
@Entity('puzzles')classes): consolidating the two entities changes the TypeORM schema for thepuzzlestable and needs an explicit data migration plus repointing the migration module — an architecture change beyond docs.unsafe-inline/unsafe-eval): needs an environment-scoped policy split (production strict vs development relaxed) and Swagger/docsexception design.These remain open for a focused backend PR.
Acceptance criteria covered
CODEOWNERSexists in the repositoryCONTRIBUTING.mdnames every command needed to reproduce the CI checks that existMakefile,backend/package.json, and the workflow files)Closes #520
Closes #524
closes #534
closes #527