Skip to content

docs: fix CODEOWNERS onchain paths and document full check suite in CONTRIBUTING.md - #647

Merged
dzekojohn4 merged 1 commit into
UnityChainxx:mainfrom
DanielCharis1:fix/danielcharis1-issues-534-527-524-520
Sep 30, 2026
Merged

dzekojohn4 merged 1 commit into
UnityChainxx:mainfrom
DanielCharis1:fix/danielcharis1-issues-534-527-524-520

Conversation

@DanielCharis1

@DanielCharis1 DanielCharis1 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Resolves the two documentation issues assigned to @DanielCharis1. The two backend code issues (#534, #527) require schema/CSP design changes and are not included here — see "Remaining issues" below.

Changes

#520 — CODEOWNERS lists onchain paths that do not exist and calls the Rust contracts Cairo

  • Replaced the nonexistent /onchain/src/ and /onchain/tests/ paths with the real contract crates: /onchain/contracts/, stellar_hunts, stellar_hunts_nft, stellar_hunts_receiver, stellar_hunts_types.
  • Corrected the section comment from "Onchain (Cairo smart contracts)" to "Onchain (Rust / Soroban smart contracts)".
  • Removed the leftover template placeholder text ("Replace the placeholder handles below...").
  • Verified every path in the file exists in the repository (while read -r p _; do [ -e "${p#/}" ] || echo "missing: $p"; done < <(grep '^/' .github/CODEOWNERS) — no output).

#524 — CONTRIBUTING.md documents no way to run the backend e2e suite or the security scans

  • Added a Backend E2E Tests section: where the specs live (backend/test/), the Jest config (backend/test/jest-e2e.json), the run commands (npm run test:e2e, make test-backend-e2e, single-spec filtering), and the Postgres/Redis requirement.
  • Added a Running the full check suite section covering:
    • make ci as the one-command entry point
    • backend unit tests and e2e suite (required)
    • onchain cargo fmt / cargo build / cargo test (required)
    • cargo deny --locked check advisories licenses bans sources (required)
    • npm audit --audit-level=critical (required) vs --audit-level=high (advisory)
    • gitleaks secret scanning (advisory)
  • Each check is marked required or advisory with the originating workflow file (.github/workflows/build.yml / .github/workflows/security.yml) named, and SECURITY.md is linked for the security-gate status.

Remaining issues (not in this PR)

These remain open for a focused backend PR.

Acceptance criteria covered

Closes #520
Closes #524
closes #534
closes #527

…ONTRIBUTING.md

- CODEOWNERS (issue UnityChainxx#520): replace the nonexistent onchain/src/ and
  onchain/tests/ paths with the real contract crates under
  onchain/contracts/, correct "Cairo" to "Rust / Soroban", and drop the
  leftover template placeholder comment. Every path in the file now
  exists in the repository.
- CONTRIBUTING.md (issue UnityChainxx#524): add a "Backend E2E Tests" section
  (backend/test/, jest-e2e.json, make test-backend-e2e) and a
  "Running the full check suite" section documenting make ci, the
  onchain cargo deny audit, npm audit gates and the gitleaks secret
  scan, each marked required or advisory with links to the workflow
  files.

Closes UnityChainxx#520
Closes UnityChainxx#524

Generated with Codebuff 🤖
Co-Authored-By: Codebuff <noreply@codebuff.com>
@drips-wave

drips-wave Bot commented Sep 29, 2026

Copy link
Copy Markdown

@DanielCharis1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@dzekojohn4 dzekojohn4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzekojohn4
dzekojohn4 merged commit d9cb22c into UnityChainxx:main Sep 30, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants