Repository navigation
Pictures in What's New fit the note, and a click shows them larger - #172
Merged
Merged
Conversation
… smaller than it is Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r than it is Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed in the browser from there Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a click shows them larger Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…there when it helps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rger on a click Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es, and is named by its description Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… is named by its description Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s it smaller than it is Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…user back Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rt GIF shows a movement Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Pictures in What's New stay a comfortable size next to the text and show larger on a click; the release-notes skill now says how to take a picture or a GIF that reads well there, and when to leave it out.
Release note
Improved: Pictures in What's New fit the note, and a click shows them larger
Pictures in What's New now stay a comfortable size next to the text. Click one to see it larger over the dialog; click again or press Esc to go back, or open it in your browser.
Current behavior
A picture in What's New took the note's full width at any height (a tall screenshot pushed the notes after it away), and a click opened it in the browser. The skill said nothing about how to take a picture, so notes carried whole-window screenshots too small to read.
Behavior with this pull request
release-notesskill has a "Pictures and GIFs" section: a picture only when it adds to the note; cropped to what the note is about (the popup, the zone of a panel) with just enough around it to place it; wider than tall; sandbox content in the light theme;playwright-cli screenshot <ref>for an element crop; alt text that says what it shows. A short looping GIF (3 to 8 s, about 12 fps, a few MB) when the note delivers a movement, with the ffmpeg command that turns aplaywright-clirecording into one, cropped; never a video file, which What's New can't show.How it was implemented
pictureEnlarges(naturalWidth, shownWidth),pictureLabel,pictureTitle(components/inlinePictureView.ts, tested): when a click enlarges, and what the picture is called.usePictureEnlarges: measures the picture again with aResizeObserverwhile it is shown, so a narrower window that shrinks the dialog makes a whole picture clickable.InlinePictureis a button (disabled when it can't enlarge) capped at 360 px tall in CSS;PictureViewer(components/) is a Radix dialog opened withopenDialog, stacked over What's New (its backdrop a layer above the dialog's content: 802/803), the picture fitted withobject-fit: contain.Behavior changes
A click on a picture in What's New no longer opens the browser directly; "Open in Browser" is in the larger view.
Checklist
npm run typecheckandnpm testpass (8,575). New tests: when a click enlarges (with a pixel of rounding), the picture's name with and without a description and whether it enlarges, the larger view's title.UVCS_PREVIEW_UPDATE, both themes, a 600 px window and a narrow one: a square picture held at 360 px; a 120 px one at its own size, not clickable; a 300 px one becoming clickable when the window narrows and not when it widens again; the larger view over the dialog, dimming it; focus on Close; Esc, a click on the backdrop and on the picture each close only the larger view. (The app's window wasn't painting frames while hidden, which stopsResizeObserverandrequestAnimationFrame; a screenshot forces a frame, which is how the resize was checked.)npm run e2e: not needed; no view, startup orcmcommand changes.imagesstayschipthere).docs/says what's now true:docs/features/updates.md"What's New".Fixed issues
None.
🤖 Generated with Claude Code