Skip to content

Phase 3: Refactor ShellNavigationService to use DI #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
Sep 1, 2026
Merged

Phase 3: Refactor ShellNavigationService to use DI #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions TransactionProcessor.Mobile/Extensions/MauiAppBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,6 @@ public static HttpMessageHandler GetHandler() {

public static MauiAppBuilder ConfigureUIServices(this MauiAppBuilder builder) {
builder.Services.AddSingleton<IDialogService, DialogService>();
builder.Services.AddTransient<Func<MyAccountAddressesPage>>(serviceProvider =>
() => serviceProvider.GetRequiredService<MyAccountAddressesPage>());
builder.Services.AddSingleton<INavigationService, ShellNavigationService>();
builder.Services.AddSingleton<IApplicationInfoService, ApplicationInfoService>();
builder.Services.AddSingleton<IApplicationUpdateLauncherService, ApplicationUpdateLauncherService>();
Expand Down
8 changes: 2 additions & 6 deletions TransactionProcessor.Mobile/UIServices/ShellNavigationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,11 @@ namespace TransactionProcessor.Mobile.UIServices;
public class ShellNavigationService : INavigationService
{
private readonly INavigationParameterService NavigationParameterService;
private readonly Func<MyAccountAddressesPage> MyAccountAddressesPageFactory;

#region Methods

public ShellNavigationService(INavigationParameterService navigationParameterService,
Func<MyAccountAddressesPage> myAccountAddressesPageFactory) {
public ShellNavigationService(INavigationParameterService navigationParameterService) {
this.NavigationParameterService = navigationParameterService;
this.MyAccountAddressesPageFactory = myAccountAddressesPageFactory;
}

public async Task QuitApplication(){
Expand Down Expand Up @@ -175,8 +172,7 @@ public async Task GoToViewLogsPage() {
}

public async Task GoToMyAccountAddresses() {
MyAccountAddressesPage p = this.MyAccountAddressesPageFactory();
await this.NavigateTo(p);
await this.NavigateTo(nameof(MyAccountAddressesPage));
}

public async Task GoToMyAccountContacts() {
Expand Down
Loading