Skip to content

refactor: reduce ProcessTransactionForFileLine complexity #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
Oct 10, 2026
Merged

refactor: reduce ProcessTransactionForFileLine complexity #823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 79 additions & 72 deletions FileProcessor.BusinessLogic/Services/FileProcessorDomainService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,78 +333,11 @@ public async Task<Result> ProcessTransactionForFileLine(FileCommands.ProcessTran
FileLineProcessingContext processingContext = new(command);
Result dispatchFailureResult = null;
Result result = await ApplyFileUpdates(async (FileAggregate fileAggregate) => {
FileDetails fileDetails = fileAggregate.GetFile();
processingContext.EstateId = fileDetails.EstateId;
processingContext.MerchantId = fileDetails.MerchantId;
processingContext.FileProfileId = fileDetails.FileProfileId;
FileLineProcessingDiagnostics.LineProcessingStarted(processingContext);

processingContext.Stage = FileLineProcessingStage.FileLineLookup;
if (fileDetails.FileLines.Any() == false) {
return Result.Invalid($"File Id [{command.FileId}] has no lines added");
}

FileLine fileLine = fileDetails.FileLines.SingleOrDefault(f => f.LineNumber == command.LineNumber);

if (fileLine == null) {
return Result.NotFound($"File Line Number {command.LineNumber} not found in File Id {command.FileId}");
}

if (fileLine.ProcessingResult != ProcessingResult.NotProcessed) {
// Line already processed
FileLineProcessingDiagnostics.LineProcessingSkipped(processingContext, fileLine.ProcessingResult);
return Result.Success();
}

processingContext.Stage = FileLineProcessingStage.FileProfileLookup;
Result<FileProfileModel> fileProfileResult = await this.FileProcessorManager.GetFileProfile(fileDetails.FileProfileId, cancellationToken);

if (fileProfileResult.IsFailed)
return ResultHelpers.CreateFailure(fileProfileResult);

FileProfileModel fileProfile = fileProfileResult.Data;
processingContext.OperatorName = fileProfile.OperatorName;

Result stateResult;

// Determine if we need to actually process this file line
processingContext.Stage = FileLineProcessingStage.LineIgnoreEvaluation;
if (this.FileLineCanBeIgnored(fileLine.LineData, fileProfile.FileFormatHandler))
{
processingContext.Stage = FileLineProcessingStage.FileLineStateUpdate;
// Write something to aggregate to say line was explicity ignored
stateResult = fileAggregate.RecordFileLineAsIgnored(fileLine.LineNumber);
if (stateResult.IsFailed)
return stateResult;
FileLineProcessingDiagnostics.LineIgnored(processingContext);
processingContext.Stage = FileLineProcessingStage.FileLineStatePersisted;
return Result.Success();
}

processingContext.Stage = FileLineProcessingStage.TransactionDetailsParsing;
Result<Dictionary<String, String>> metadataResult = this.BuildTransactionMetadata(command, fileLine, fileProfile, out String parsedOperatorName);
processingContext.OperatorName = parsedOperatorName;
if (metadataResult.IsFailed) {
processingContext.Stage = FileLineProcessingStage.FileLineStateUpdate;
stateResult = fileAggregate.RecordFileLineAsRejected(fileLine.LineNumber, "Invalid Format");
if (stateResult.IsFailed)
return ResultHelpers.CreateFailure(stateResult);

if (stateResult.IsSuccess)
{
FileLineProcessingDiagnostics.LineRejected(processingContext, "Invalid Format");
processingContext.Stage = FileLineProcessingStage.FileLineStatePersisted;
}
return stateResult;
}

(stateResult, dispatchFailureResult) = await this.ProcessTransaction(fileAggregate,
command,
fileDetails,
fileProfile,
metadataResult.Data,
processingContext,
cancellationToken);
(Result stateResult, Result dispatchResult) = await this.ProcessTransactionForFileLineInternal(fileAggregate,
command,
processingContext,
cancellationToken);
dispatchFailureResult = dispatchResult;
return stateResult;
}, command.FileId, cancellationToken);

Expand All @@ -424,6 +357,80 @@ public async Task<Result> ProcessTransactionForFileLine(FileCommands.ProcessTran
return result;
}

private async Task<(Result StateResult, Result DispatchFailureResult)> ProcessTransactionForFileLineInternal(FileAggregate fileAggregate,
FileCommands.ProcessTransactionForFileLineCommand command,
FileLineProcessingContext processingContext,
CancellationToken cancellationToken)
{
FileDetails fileDetails = fileAggregate.GetFile();
processingContext.EstateId = fileDetails.EstateId;
processingContext.MerchantId = fileDetails.MerchantId;
processingContext.FileProfileId = fileDetails.FileProfileId;
FileLineProcessingDiagnostics.LineProcessingStarted(processingContext);

processingContext.Stage = FileLineProcessingStage.FileLineLookup;
if (fileDetails.FileLines.Any() == false)
return (Result.Invalid($"File Id [{command.FileId}] has no lines added"), null);

FileLine fileLine = fileDetails.FileLines.SingleOrDefault(f => f.LineNumber == command.LineNumber);
if (fileLine == null)
return (Result.NotFound($"File Line Number {command.LineNumber} not found in File Id {command.FileId}"), null);

if (fileLine.ProcessingResult != ProcessingResult.NotProcessed)
{
FileLineProcessingDiagnostics.LineProcessingSkipped(processingContext, fileLine.ProcessingResult);
return (Result.Success(), null);
}

processingContext.Stage = FileLineProcessingStage.FileProfileLookup;
Result<FileProfileModel> fileProfileResult = await this.FileProcessorManager.GetFileProfile(fileDetails.FileProfileId, cancellationToken);
if (fileProfileResult.IsFailed)
return (ResultHelpers.CreateFailure(fileProfileResult), null);

FileProfileModel fileProfile = fileProfileResult.Data;
processingContext.OperatorName = fileProfile.OperatorName;

processingContext.Stage = FileLineProcessingStage.LineIgnoreEvaluation;
if (this.FileLineCanBeIgnored(fileLine.LineData, fileProfile.FileFormatHandler))
{
processingContext.Stage = FileLineProcessingStage.FileLineStateUpdate;
Result stateResult = fileAggregate.RecordFileLineAsIgnored(fileLine.LineNumber);
if (stateResult.IsFailed)
return (stateResult, null);

FileLineProcessingDiagnostics.LineIgnored(processingContext);
processingContext.Stage = FileLineProcessingStage.FileLineStatePersisted;
return (Result.Success(), null);
}

processingContext.Stage = FileLineProcessingStage.TransactionDetailsParsing;
Result<Dictionary<String, String>> metadataResult = this.BuildTransactionMetadata(command, fileLine, fileProfile, out String parsedOperatorName);
processingContext.OperatorName = parsedOperatorName;
if (metadataResult.IsFailed)
{
processingContext.Stage = FileLineProcessingStage.FileLineStateUpdate;
Result stateResult = fileAggregate.RecordFileLineAsRejected(fileLine.LineNumber, "Invalid Format");
if (stateResult.IsFailed)
return (ResultHelpers.CreateFailure(stateResult), null);

if (stateResult.IsSuccess)
{
FileLineProcessingDiagnostics.LineRejected(processingContext, "Invalid Format");
processingContext.Stage = FileLineProcessingStage.FileLineStatePersisted;
}

return (stateResult, null);
}

return await this.ProcessTransaction(fileAggregate,
command,
fileDetails,
fileProfile,
metadataResult.Data,
processingContext,
cancellationToken);
}

private async Task<(Result StateResult, Result DispatchFailureResult)> ProcessTransaction(FileAggregate fileAggregate,
FileCommands.ProcessTransactionForFileLineCommand command,
FileDetails fileDetails,
Expand Down
Loading