Skip to content

refactor: reduce ProcessTransactionForFileLine complexity - #823

Merged
StuartFerguson merged 1 commit into
mainfrom
bug/#710_processtransactionforfileline_complexity_changes
Oct 10, 2026
Merged

StuartFerguson merged 1 commit into
mainfrom
bug/#710_processtransactionforfileline_complexity_changes

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • Extract line lookup, profile, ignore, rejection, and transaction dispatch preparation from ProcessTransactionForFileLine.
  • Preserve the existing public contract and processing behavior.

Validation

  • FileProcessor.BusinessLogic.Tests: 100 passed.
  • Full solution build completed successfully.
  • Full solution test run reached integration tests, which produced no output and was stopped manually.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T08:41:52.203735Z f4bd509 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@StuartFerguson
StuartFerguson merged commit 3c46a05 into main Oct 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Codacy] Method FileProcessorDomainService::ProcessTransactionForFileLine has a cyclomatic complexity of 14 (limit is 12)

1 participant