Skip to content

extractor: Setup signing and publishing for CI snapshots#1463

Merged
TobiGr merged 1 commit intodevfrom
snapshot
Mar 1, 2026
Merged

extractor: Setup signing and publishing for CI snapshots#1463
TobiGr merged 1 commit intodevfrom
snapshot

Conversation

@theimpulson
Copy link
Copy Markdown
Member

Summary

This PR:

  • Sets up signing and publishing for CI snapshots on Maven Central

Guidelines

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@theimpulson theimpulson requested review from Stypox and TobiGr February 28, 2026 03:52
@theimpulson
Copy link
Copy Markdown
Member Author

I couldn't verify the publishing as the secrets seems to be only available to a protected branch (?)

@TobiGr
Copy link
Copy Markdown
Contributor

TobiGr commented Feb 28, 2026

I setup a minimal branch protection rule
@Stypox set the variables. so he might know more.

The workflow is only running on dev, so it won't run here.

@theimpulson
Copy link
Copy Markdown
Member Author

The workflow is only running on dev, so it won't run here.

I need permission to push to the current snapshot branch without a PR or by force push to test changes as now its protected.

@TobiGr
Copy link
Copy Markdown
Contributor

TobiGr commented Feb 28, 2026

I removed the branch protection rule

Copy link
Copy Markdown
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread .github/workflows/snapshot.yml
Comment thread extractor/build.gradle.kts Outdated
Comment thread .github/workflows/snapshot.yml
@theimpulson
Copy link
Copy Markdown
Member Author

Seems to be working fine, so I will go ahead and remove the branch from the workflow file to limit it to dev and manual trigger.

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 1, 2026

Copy link
Copy Markdown
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This can be merged from my side! Maybe let's wait for @TobiGr to confirm

Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go ahead and test it

@TobiGr TobiGr merged commit c627a8e into dev Mar 1, 2026
3 checks passed
@TobiGr TobiGr deleted the snapshot branch March 2, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants