libs: Sync extractor from mavencentral's snapshot repository#13297
Closed
theimpulson wants to merge 1 commit intodevfrom
Closed
libs: Sync extractor from mavencentral's snapshot repository#13297theimpulson wants to merge 1 commit intodevfrom
theimpulson wants to merge 1 commit intodevfrom
Conversation
Also gate snapshot repository for our own group only Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Stypox
approved these changes
Mar 1, 2026
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
LGTM, can be merged once the extractor PR is merged. I am still worried how we will be able to test extractor PRs in NewPipe: now it will become impossible to just depend on any commit hash from any extractor fork during development, without manually cloning the extractor repo side by side and editing settings.gradle. Maybe we can add a CI step in the extractor CI that builds an APK based on the latest NewPipe dev?
Member
Member
Yeah, indeed |
Member
Author
|
Closing in favor of git repository PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence