Skip to content

[YouTube] Speed up n parameter presence check #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TobiGr merged 2 commits into from
Jul 12, 2025
Merged

[YouTube] Speed up n parameter presence check #1330

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5184231
Do a quick check if the n parameter is even present before exec regex
litetex Jul 10, 2025
0dfaeb2
Added doc for related code
litetex Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...n/java/org/schabi/newpipe/extractor/services/youtube/YoutubeThrottlingParameterUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
*/
final class YoutubeThrottlingParameterUtils {

// NOTE: When changing this you should also change the quick exit/shortcut
// in getThrottlingParameterFromStreamingUrl
private static final Pattern THROTTLING_PARAM_PATTERN = Pattern.compile("[&?]n=([^&]+)");

private static final String SINGLE_CHAR_VARIABLE_REGEX = "[a-zA-Z0-9$_]";
Expand Down Expand Up @@ -196,6 +198,11 @@ static String getDeobfuscationFunction(@Nonnull final String javaScriptPlayerCod
*/
@Nullable
static String getThrottlingParameterFromStreamingUrl(@Nonnull final String streamingUrl) {
// Do a quick check if the n parameter is even present, if not abort
// This improves performance by 60-900x
if (!streamingUrl.contains("&n=") && !streamingUrl.contains("?n=")) {
return null;
}
try {
return Parser.matchGroup1(THROTTLING_PARAM_PATTERN, streamingUrl);
} catch (final Parser.RegexException e) {
Expand Down
Loading