[YouTube] Speed up n parameter presence check#1330
Merged
TobiGr merged 2 commits intoTeamNewPipe:devfrom Jul 12, 2025
Merged
Conversation
7727521 to
5184231
Compare
Contributor
|
Good catch! You might want to add a comment to |
Member
Author
|
@TobiGr done :) |
TobiGr
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code does a quick check if the n parameter is even present before running the extraction regex.
The time required to extract an url that does not contain the n-parameter got down from:
Example: Timings of
getThrottlingParameterFromStreamingUrlin ns when runningYoutubeStreamExtractorRelatedMixTest:Before:
After: