[Backport] Feature: Divide player seekbar by chapters#13430
Open
Ecomont wants to merge 3 commits intoTeamNewPipe:devfrom
Open
[Backport] Feature: Divide player seekbar by chapters#13430Ecomont wants to merge 3 commits intoTeamNewPipe:devfrom
Ecomont wants to merge 3 commits intoTeamNewPipe:devfrom
Conversation
…ies and add haptic feedback for chapter navigation
7 tasks
ShareASmile
added
feature request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This is the requested backport of PR #13413 to the
devbranch to maintain feature parity.It includes the original Java implementation of the
ChaptersSeekBarwith visual markers, gap rendering based on video metadata (StreamInfo), and haptic feedback, exactly as they were implemented before the Kotlin migration requested for therefactorbranch.Before/After Screenshots/Screen Record
(Same UI changes as demonstrated in #13413)
After:
https://github.com/user-attachments/assets/80f2cf57-d500-4670-bcd5-4e45c6d4fdcf
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence