Feature: Divide player seekbar by chapters (#6270)#13413
Open
Ecomont wants to merge 12 commits intoTeamNewPipe:refactorfrom
Open
Feature: Divide player seekbar by chapters (#6270)#13413Ecomont wants to merge 12 commits intoTeamNewPipe:refactorfrom
Ecomont wants to merge 12 commits intoTeamNewPipe:refactorfrom
Conversation
ShareASmile
added
feature request
theimpulson
requested changes
Apr 16, 2026
Member
theimpulson
left a comment
theimpulson
left a comment
There was a problem hiding this comment.
Thank you, seems quite nice change.
Member
|
As this isn't compose-specific, this should be backported to dev as well to keep feature-parity. |
Ecomont
force-pushed
the
feature/chapter-markers-seekbar-on-refactor
branch
from
1de5c38 to
413aaf3
Compare
Ecomont
force-pushed
the
feature/chapter-markers-seekbar-on-refactor
branch
from
413aaf3 to
27df290
Compare
github-actions
bot
added
size/giant
7 tasks
Author
|
@theimpulson The backport for the dev branch is now ready, you can find it here #13430 I've ported the original Java implementation exactly as requested to maintain feature parity. Let me know if there's anything else needed on either of the PRs |
theimpulson
requested changes
Apr 19, 2026
Contributor
|
Please rebase your PR |
Ecomont
force-pushed
the
feature/chapter-markers-seekbar-on-refactor
branch
from
9220114 to
d520f8a
Compare
…ies and add haptic feedback for chapter navigation
…ePlayerGestureListener
…nd enhance chapter marker handling
Ecomont
force-pushed
the
feature/chapter-markers-seekbar-on-refactor
branch
from
d520f8a to
80d0396
Compare
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
ChaptersSeekBar) to represent chapter divisions.StreamInfo) and mapped it to the seekbar's layout bounds using transparent gaps (PorterDuff.Mode.CLEAR).HapticFeedbackConstants.CLOCK_TICK) when the user scrubs past a chapter boundary, providing a seamless visual and tactile experience similar to the original YouTube app.Before/After Screenshots/Screen Record
Before:
https://github.com/user-attachments/assets/5da1b3e1-c701-4db0-bf70-21b020d9fd71
After:
https://github.com/user-attachments/assets/80f2cf57-d500-4670-bcd5-4e45c6d4fdcf
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence