Skip to content

Fix playlist item dragging video to only neighbor positions#13049

Merged
TobiGr merged 1 commit intodevfrom
unknown repository
Jan 12, 2026
Merged

Fix playlist item dragging video to only neighbor positions#13049
TobiGr merged 1 commit intodevfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 12, 2026

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

Fix playlist item dragging video to only neighbor positions

Call saveImmediate only after used actually dropped item instead of every time View is updated which happens several times to show user a feedback where item would be moved

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Call `saveImmediate` only after used actually dropped item instead
of every time View is updated which happens several times to show
user a feedback where item would be moved
@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label Jan 12, 2026
Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@TobiGr TobiGr added bug Issue is related to a bug GUI Issue is related to the graphical user interface playlist Anything to do with playlists in the app labels Jan 12, 2026
@TobiGr TobiGr merged commit 77d62de into TeamNewPipe:dev Jan 12, 2026
6 checks passed
@ghost ghost deleted the playlist_bug branch January 12, 2026 20:30
@yehu-hunter
Copy link
Copy Markdown

Hi! Does that mean this will go into the next update? Am having this issue as well.

@jstetten
Copy link
Copy Markdown

Hi! Does that mean this will go into the next update? Am having this issue as well.

Hello. I would also like to ask if there are any plans for a hot fix release for this...as well as a few other new bugs introduced by the new release. This playlist bug is a show stopper for me, so I had to downgrade to the previous version.

@dustdfg, I tried your debug APK, and that did indeed fix the dragging problem. Thank you! However, it also introduced a new problem for me where my entire history pane never loads no matter what, despite those history entries being present in the database.

@TobiGr
Copy link
Copy Markdown
Contributor

TobiGr commented Jan 16, 2026

My plan is to make a hotfix on the weekend, probably on Sunday.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 16, 2026

@dustdfg, I tried your debug APK, and that did indeed fix the dragging problem. Thank you! However, it also introduced a new problem for me where my entire history pane never loads no matter what, despite those history entries being present in the database.

If it is a bug so please fill a new issue and provide more details how to reproduce and notice it

@jstetten
Copy link
Copy Markdown

@dustdfg, I tried your debug APK, and that did indeed fix the dragging problem. Thank you! However, it also introduced a new problem for me where my entire history pane never loads no matter what, despite those history entries being present in the database.

If it is a bug so please fill a new issue and provide more details how to reproduce and notice it

Thanks for the quick reply.

I tested things out and found out the empty history pane bug does not appear if using the app fresh on install, but only specifically after importing my (non-debug 0.28.0) zip into your 0.28.1 debug apk. Nothing shows in history no matter how many videos I watch at this point. (See screenshot.)

20260116_041748

The situation can be fixed though by clicking Clear watch history via the UI. After this, the history pane works as it should (minus the loss of years worth of watch history).

Sorry, I've been absent from this community for a while. Do you guys know if this bug is actually something real or is just an artifact of importing a DB between two different builds and versions? If so, where are debug issues reported?

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 16, 2026

@jstetten

  1. Can't reproduce
  2. Try https://github.com/TeamNewPipe/NewPipe-nightly/releases/tag/nightly-1103
  3. I really suggest you filling github issue

@ghost ghost mentioned this pull request Jan 16, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug GUI Issue is related to the graphical user interface playlist Anything to do with playlists in the app size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drag problem while re-ordering items in a bookmarked playlist

3 participants