Improve/Fix primaryControls layout in player

[litetex]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Supersedes [player] Fix non-fullscreen layout regression #12711
• Fixes the regression introduced in Fix Long Audio/Dubs text label puses UI Controls on Player Off Screen in Portrait mode.  #12699 / Long Audio/Dubs text label pushes UI Controls on Player Off Screen in Portrait mode. #12499
• Doesn't require code changes or hard-coded limits to properly display the elements

Before/After Screenshots/Screen Record

• Before: See [player] Fix non-fullscreen layout regression #12711
• After:

About the Popup Player

The popup player is still broken but it was broken before (basically since the introduction of audioTrackTextView a few years ago)

I tried a few quick/dirty fixes - like limiting the maxWidth of audioTrackTextView - however the results were worse than before so I aborted doing any changes there for now.

This can likely only be fixed with a major rework how the topControls are handled in the player.
There should be different fragments, one for the main player (that basically represents the current layout) and one for popup (where everything is next to each other). This way the spacing can be done correctly. It would also make the player UI a lot cleaner.

Maybe we can also sit this problem out / it's fixed with refactor/NewPlayer...

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[Stypox]

Thanks!

The popup player is still broken but it was broken before (basically since the introduction of audioTrackTextView a few years ago)

Yeah it's the same change that also broke the main player, and #12699 was the first attempt to fix it.

I tried a few quick/dirty fixes - like limiting the maxWidth of audioTrackTextView - however the results were worse than before so I aborted doing any changes there for now.

Doesn't just setting the max width of audioTrackTextView to something very small (e.g. 48dp) fix it? Or are there more layout problems then?

[litetex]

Doesn't just setting the max width of audioTrackTextView to something very small (e.g. 48dp) fix it? Or are there more layout problems then?

Nope, because:

1. When the popup player is small it still grows and pushes the full screen out of the window
   
2. When the popup player is large it stops growing, despite having space left
   

I also tried things like match_parent or 0dp as a width but this doesn't seem to work either.

[Stypox]

Yeah that's what I'd have expected, but for now it's still better than having a huge button always pushing the other buttons away

[litetex]

Yeah that's what I'd have expected, but for now it's still better than having a huge button always pushing the other buttons away

Anyway can we get this fix reviewed/merged so that we have at least a working main player.
I can make a separate PR that "fixes" the popup player.

PR with a maxWidth set for popup player: #12729

[Stypox]

Code LGTM. I tested and it seems to work as expected. Thanks!