[player] Fix non-fullscreen layout regression

[Ljn0626]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Removed binding.metadataView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
• Updated the layout: increased audioTrackTextView’s layout_weight to 2

Before/After Screenshots/Screen Record

• Before: When not in fullscreen, all other items are no longer correctly aligned to the right side

• After: It displays correctly on both small and medium phones.

Fixes the following issue(s)

• Follow-up to Issue#12499

Relies on the following changes

• android:layout_weight="2" ->android:layout_weight="2"
• delete binding.metadataView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[Stypox]

Thanks! Now the language chooser does not seems to expand to take up as much space as it needs though

[litetex]

There are still layouting problems as can be seen above in the screenshots.

After doing some experiments I think it's impossible to fix this properly without introducing at least one layout that wraps the metadataView and audioTrackTextView.

Otherwise the layouts constantly "fight" each other or leave some empty, unused spaces:

I will try to have a look into this again tomorrow...

PS: We should also fix the issue/PR image resizer because my mouse wheel is now on fire.

[Ljn0626]

I’m not sure if this makes sense, but I added an empty <View> as a spacer.
It only becomes visible (with weight) when both metadataView and audioTrackTextView are not present.
This is to ensure that audioTrackTextView can expand to take up as much space as it needs when visible, while keeping the right-side buttons properly aligned.

[litetex]

I think we can close this in favor of my PR

[Stypox]

Closing in favour of #12714. Thanks anyway! :-)