Fix Long Audio/Dubs text label puses UI Controls on Player Off Screen in Portrait mode.

[Ljn0626]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Constrain audioTrackTextView width (maxWidth="110dp") and single line + ellipsize="end" + scrollHorizontally="true", so it never wraps or steals too much space.

Before/After Screenshots/Screen Record

• Before: With long English/Spanish labels, the More options button could be pushed off-screen

• After: Right-side controls remain visible; the audio track label stays on a single line with ellipsis

Fixes the following issue(s)

• Fixes Long Audio/Dubs text label pushes UI Controls on Player Off Screen in Portrait mode. #12499

Relies on the following changes

• android:singleLine="true"
android:ellipsize="end"
android:scrollHorizontally="true"
android:maxWidth="110dp"

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[TobiGr]

Thank you for the PR.
Setting a max width might not be the best approach to solve this problem as demonstrated on different screen sizes below:

small screen	medium / large screen
The arrow button to expand the menu is barely on screen	There is plenty of room left which could be used to show more information about the selected audio track

An alternative could be to set the layout_width to zero and sepcify a layout_weight.

[Ljn0626]

I think now it works. The results are as follows:

[TobiGr]

Thank you. Just squash your last two commits and set a helpful commit message and after that we are good to go!

[Ljn0626]

Done — I’ve squashed the last two commits into one.

[TobiGr]

Thanks. Please take a look at your commit message again.
The first line should be descritptive and tell the reader what was changed in the commit, e.g. [player] Fixed long audio track label pushing controls off screen. The next line can contain more detail information why the change was made or how it is implented. You squashed your commits - which is good - but this also means that you need to take a look at the commit message again. In that commit you neither "Replace marginRight with marginEnd to support RTL" nor "use layout_weight instead of maxWidth" - maxWidth does not occur in the code changes at all.

[Ljn0626]

Thanks, and sorry for the confusion. I removed the bullets that weren’t reflected in the final diff and amended the message to accurately describe the changes (weight-based layout for audioTrackTextView, singleLine+ellipsis, and hiding metadataView when not fullscreen).

[TobiGr]

Thank you

[litetex]

Hey I think this PR broke the player (if not in full screen):

It looks like all other items are now no longer correctly aligned to the right side...

[Stypox]

@Ljn0626 could you open another PR to fix the problem reported by @litetex? Thanks in advance :-)

[Ljn0626]

Thanks for the report — you’re right, my previous change inadvertently hid metadataView, which removed its weight from the row and broke the right-end alignment in non-fullscreen. Sorry for the regression — fix incoming.