Skip to content

Issue#12443 #12608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cp89cyber wants to merge 2 commits into from
Closed

Issue#12443 #12608

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1de4da9
Use fragment base time when muxing MP4
cp89cyber Sep 6, 2025
01eea2c
Merge pull request #2 from cp90-pixel/codex/fix-downloader-mp4-muxing…
cp89cyber Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions app/src/main/java/org/schabi/newpipe/streams/Mp4FromDashWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,12 @@ public void build(final SharpStream output) throws IOException {
Mp4DashChunk chunk;
while ((chunk = readers[i].getNextChunk(true)) != null) {

if (defaultMediaTime[i] < 1 && chunk.moof.traf.tfhd.defaultSampleDuration > 0) {
defaultMediaTime[i] = chunk.moof.traf.tfhd.defaultSampleDuration;
if (defaultMediaTime[i] < 1) {
if (chunk.moof.traf.tfdt > 0) {
defaultMediaTime[i] = (int) chunk.moof.traf.tfdt;
} else if (chunk.moof.traf.tfhd.defaultSampleDuration > 0) {
defaultMediaTime[i] = chunk.moof.traf.tfhd.defaultSampleDuration;
}
}

read += chunk.moof.traf.trun.chunkSize;
Expand Down Expand Up @@ -763,8 +767,8 @@ private void makeTrak(final int index, final long duration, final int defaultMed
final int mediaTime;

if (tracks[index].trak.edstElst == null) {
// is a audio track ¿is edst/elst optional for audio tracks?
mediaTime = 0x00; // ffmpeg set this value as zero, instead of defaultMediaTime
// there is no edit list, use the first decode timestamp as start time
mediaTime = defaultMediaTime;
bMediaRate = 0x00010000;
} else {
mediaTime = (int) tracks[index].trak.edstElst.mediaTime;
Expand Down