Issue#12443#12608
Closed
cp89cyber wants to merge 2 commits intoTeamNewPipe:devfrom
cp89cyber:issue#12443
Closed
Conversation
…-issue Handle fragment base time in mp4 muxer
Member
|
Thank you for this PR! Could you please change the title of the PR to briefly describe what it fixes, and also, for next time, please follow the PR template ;-) It would be good if you could add two very short (e.g. 1s) sample video + audio that were previously misbehaving, along with a unit test that tries to mux those two together and checks that the result is properly muxed? This might be hard to do, let me know if you'd prefer to skip it.
That's an issue with your setup, you need to download the Android SDK and specify its location :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrected the MP4 DASH writer to capture each fragment’s base decode time (tfdt) and use it as the default media timestamp, ensuring proper alignment of combined streams
Updated the track-building logic to apply this base timestamp when no edit list is present so playback starts at the proper point in muxed outputs
Testing