Skip to content

Issue#12443#12608

Closed
cp89cyber wants to merge 2 commits intoTeamNewPipe:devfrom
cp89cyber:issue#12443
Closed

Issue#12443#12608
cp89cyber wants to merge 2 commits intoTeamNewPipe:devfrom
cp89cyber:issue#12443

Conversation

@cp89cyber
Copy link
Copy Markdown

Summary

  • Corrected the MP4 DASH writer to capture each fragment’s base decode time (tfdt) and use it as the default media timestamp, ensuring proper alignment of combined streams

  • Updated the track-building logic to apply this base timestamp when no edit list is present so playback starts at the proper point in muxed outputs

Testing

  • ⚠️ ./gradlew test (missing Android SDK: “SDK location not found”)

@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label Sep 6, 2025
@Stypox
Copy link
Copy Markdown
Member

Stypox commented Sep 6, 2025

Thank you for this PR! Could you please change the title of the PR to briefly describe what it fixes, and also, for next time, please follow the PR template ;-)

It would be good if you could add two very short (e.g. 1s) sample video + audio that were previously misbehaving, along with a unit test that tries to mux those two together and checks that the result is properly muxed? This might be hard to do, let me know if you'd prefer to skip it.

⚠️ ./gradlew test (missing Android SDK: “SDK location not found”)

That's an issue with your setup, you need to download the Android SDK and specify its location :-)
Or just download the APK from the CI and test it out.

@cp89cyber cp89cyber closed this by deleting the head repository Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants