Skip to content

Build against SeriouslyCommonLib 20261031.5 (#688 compatibility) - #97

Merged
stephenjust merged 1 commit into
mainfrom
scl-688-compat
Nov 5, 2026
Merged

stephenjust merged 1 commit into
mainfrom
scl-688-compat

Conversation

@tblank1024

Copy link
Copy Markdown
Contributor

SeriouslyCommonLib #688 removed CANBusId.RIO and the DeviceInfo(String, int, boolean, double) constructor. main still builds only because it pins SeriouslyCommonLib 20261010.5, which predates #688. This PR moves to the current release, 20261031.5, which includes #688.

Changes

  • build.gradle: SeriouslyCommonLib 20261010.5 → 20261031.5.
  • Contract2023:
    • CANBusId.RIO → CANPort.CAN_S0, using the CANPort overloads added in #688.
    • The CANcoders use new DeviceInfo(name, CANPort.CAN_S0, id, false). The simulation scaling value (always 1.0) is gone because the field no longer exists.

No other file used the removed APIs.

Checked: ./gradlew build passes, including tests and checkstyle. It passes against Maven 20261031.5 and against a local SeriouslyCommonLib with #688 (-DuseLocalCommonLib=true), using JDK 25.

Why now: FRCRobotTemplate #96 (electrical report) needs a SeriouslyCommonLib release that has both #688 and #692. Merging this PR first keeps #96's diff to the electrical changes.

🤖 Generated with Claude Code

https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp

…places CANBusId.RIO

Contract2023 used CANBusId.RIO and the DeviceInfo(String,int,boolean,double)
constructor, both removed in SeriouslyCommonLib #688. The simulation scaling
value went with it; the CANcoders keep CAN_S0, the old default bus.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
@tblank1024
tblank1024 requested a review from a team as a code owner November 5, 2026 16:06
@stephenjust
stephenjust merged commit e4a0b33 into main Nov 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants