Repository navigation
Build against SeriouslyCommonLib 20261031.5 (#688 compatibility) - #97
Merged
Merged
Conversation
…places CANBusId.RIO Contract2023 used CANBusId.RIO and the DeviceInfo(String,int,boolean,double) constructor, both removed in SeriouslyCommonLib #688. The simulation scaling value went with it; the CANcoders keep CAN_S0, the old default bus. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
stephenjust
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SeriouslyCommonLib #688 removed
CANBusId.RIOand theDeviceInfo(String, int, boolean, double)constructor.mainstill builds only because it pins SeriouslyCommonLib20261010.5, which predates #688. This PR moves to the current release,20261031.5, which includes #688.Changes
build.gradle: SeriouslyCommonLib20261010.5→20261031.5.Contract2023:CANBusId.RIO→CANPort.CAN_S0, using theCANPortoverloads added in #688.new DeviceInfo(name, CANPort.CAN_S0, id, false). The simulation scaling value (always 1.0) is gone because the field no longer exists.No other file used the removed APIs.
Checked:
./gradlew buildpasses, including tests and checkstyle. It passes against Maven20261031.5and against a local SeriouslyCommonLib with #688 (-DuseLocalCommonLib=true), using JDK 25.Why now: FRCRobotTemplate #96 (electrical report) needs a SeriouslyCommonLib release that has both #688 and #692. Merging this PR first keeps #96's diff to the electrical changes.
🤖 Generated with Claude Code
https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp