Repository navigation
Electrical report: contract list, @ReadyWhen pattern, snapshot workflow - #96
Merged
Merged
Conversation
This was referenced Nov 4, 2026
- ElectricalContract implements XElectricalReportContract (from SeriouslyCommonLib); Hardware names back @ReadyWhen. - Contract2026 uses the library's CanBusOrderEntry. - electrical/report/Main.java lists the robots for ./gradlew electricalReport. - GitHub Action publishes JSON snapshots to the electrical-snapshots branch on merges to main, for the electrical contract web tool. Needs a SeriouslyCommonLib release containing XElectricalReportContract. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
tblank1024
force-pushed
the
electrical-report
branch
from
November 10, 2026 00:49
a0d37e9 to
c2b4580
Compare
tblank1024
marked this pull request as ready for review
November 10, 2026 00:50
stephenjust
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the electrical contract report and its web-tool workflow to the template, so the 2027 repo starts with them.
The library side is SeriouslyCommonLib #692, released as
20261109.020802.mainalready uses that version, so this PR doesn't change the version.Changes
ElectricalContractimplementsXElectricalReportContract.isReady(String)andgetHardwareNames()map to theHardwareenum. The class comment shows the pattern: tag each getter with@ReadyWhen("Shooter")and so on.getAdditionalPDHConnections()andgetAdditionalPowerBranches()moved fromElectricalContractinto the library interface.Contract2026overrides them as before.Contract2026uses the library'sCanBusOrderEntry, so its nested record is removed.electrical/report/Main.javaholds the robot list for the existing./gradlew electricalReporttask, mirroring theRobotswitch.--args="--all -d out"writes every robot..github/workflows/electrical-snapshots.ymlruns on merges tomainthat touch the contracts or the exporter, or when run by hand. It publishes JSON to theelectrical-snapshotsbranch, where the web tool reads it. It needs no secrets.Rebased on
mainafter #95 (fluent builders), #97, #98 and #99 (Spotless). There's one commit, formatted withspotlessApply.Verified locally with JDK 25, against SeriouslyCommonLib
20261109.020802from GitHub releases:./gradlew buildpasses, including tests, checkstyle andspotlessCheck.electricalReport --args="--all -d out"writes 4 robots plusindex.json:The earlier description said Competition had 39 CAN devices. That was wrong: the template's
Contract2026only defines these 14.🤖 Generated with Claude Code
https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp