Skip to content

Fix explicit Bash destinations and link entry validation - #5333

Merged
Trecek merged 42 commits into
developfrom
pr-5329-explicit-write-destinations-20261026
Oct 27, 2026
Merged

Trecek merged 42 commits into
developfrom
pr-5329-explicit-write-destinations-20261026

Conversation

@Trecek

@Trecek Trecek commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Explicit npm prefixes and ln destinations were missing from the shared Bash write scanner, allowing those commands to bypass destination checks. Recognize npm install prefixes, ln link entries, and GNU install target-directory children while preserving quoted option values and rejecting unresolved destinations.

Carry content and entry targets through write-prefix, installation, Git-ref, run_cmd, and diagnostic consumers. Entry checks resolve the parent and preserve the final basename, so replacing an outside link that points inside remains denied; content writes continue to validate the resolved referent. Document the supported forms, npm cache/script limits, and filesystem race limitations.

Regression coverage includes the full observed compound npm/ln commands at the actual write guard, sibling paths sharing an allowed root's text prefix for both content and entry targets, and long-form contradictory target-directory options.

Validation:

  • pre-commit run --all-files passed.
  • Configured task test-local-gate with conservative filtering: 46,210 passed, 510 skipped, 13 xfailed.

Closes #5329

Trecek added 30 commits October 26, 2026 12:14
@Trecek
Trecek enabled auto-merge October 27, 2026 01:40
@Trecek
Trecek added this pull request to the merge queue Oct 27, 2026
Merged via the queue into develop with commit b183012 Oct 27, 2026
11 checks passed
@Trecek
Trecek deleted the pr-5329-explicit-write-destinations-20261026 branch October 27, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant