Repository navigation
fix: reconcile inline review receipts using reviewed-head evidence - #5331
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline reviews can be posted successfully but remain
COMMITTED_PENDING_VERIFICATIONbecause review-scoped comment readback omits the coordinates needed to prove publication. Read the PR-wide collection, scope it to the selected reviews, and match original anchors against the persisted reviewed head so recovery still works after comments relocate.Both exact reconciliation and structured-422 dedup share the review-selection policy and traverse one comment collection per read. Invalid pagination links return unusable evidence while preserving the pending operation for later recovery without another POST.
Validation:
pre-commit run --all-filespassed.task test-local-gatepassed: 32,217 passed, 284 skipped, 13 xfailed.Refs #5328. This repair targets
develop; PR #5255 should be rebased after the repair is integrated.