Skip to content

fix: reconcile inline review receipts using reviewed-head evidence - #5331

Merged
Trecek merged 13 commits into
developfrom
impl-5328-review-evidence-20261026-01
Oct 26, 2026
Merged

Trecek merged 13 commits into
developfrom
impl-5328-review-evidence-20261026-01

Conversation

@Trecek

@Trecek Trecek commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Inline reviews can be posted successfully but remain COMMITTED_PENDING_VERIFICATION because review-scoped comment readback omits the coordinates needed to prove publication. Read the PR-wide collection, scope it to the selected reviews, and match original anchors against the persisted reviewed head so recovery still works after comments relocate.

Both exact reconciliation and structured-422 dedup share the review-selection policy and traverse one comment collection per read. Invalid pagination links return unusable evidence while preserving the pending operation for later recovery without another POST.

Validation:

  • pre-commit run --all-files passed.
  • Configured task test-local-gate passed: 32,217 passed, 284 skipped, 13 xfailed.
  • Retained the initial red gate with 21 new regression failures before production edits.
  • Captured a real LEFT multiline relocation in sandbox PR #50: current lines moved from 11–13 to 16–18 while original coordinates and LEFT sides remained intact.
  • Real-gateway server tests verify pending-operation replay, exactly one POST, recovered remote IDs, and independent canonical receipt verification.

Refs #5328. This repair targets develop; PR #5255 should be rebased after the repair is integrated.

@Trecek
Trecek added this pull request to the merge queue Oct 26, 2026
Merged via the queue into develop with commit c44f9ce Oct 26, 2026
10 checks passed
@Trecek
Trecek deleted the impl-5328-review-evidence-20261026-01 branch October 26, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant