Skip to content

Fix plan-set admission from sibling worktrees - #5330

Merged
Trecek merged 17 commits into
developfrom
impl-bind-containment-5324-20261025-230357
Oct 26, 2026
Merged

Trecek merged 17 commits into
developfrom
impl-bind-containment-5324-20261025-230357

Conversation

@Trecek

@Trecek Trecek commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Recipe plan sets bind in the clone, while implementation and retry run in sibling worktrees. Admission previously derived containment from the consumer cwd, rejecting a valid clone authority before worker dispatch.

Retain the resolved root and issued digest for each successful recipe bind on the context-owned materializer. Admission requires a binding for the current execution, verifies the original authority path under that root, and compares the verified digest with the issued digest. Audit inputs retain invocation-cwd containment.

Adds production bind/renew through real sibling-worktree implement and retry regression coverage, plus provenance rejection, link substitution, renewal, same-context reinstall, and separate audit-root checks. Documents the process-local lifetime and trust assumptions.

Validation:

  • pre-commit run --all-files: PASS.
  • Configured test_check / task test-local-gate with conservative filtering: 52,841 passed, 608 skipped, 26 xfailed.
  • Reproduced the original containment rejection before the fix.

Fixes #5324.

Audit evidence follow-up (R-028):

  • Replayed source commit 940f8fb79 with final test files from 579bb3f46 using the unchanged configured task test-local-gate. The complete replay retained 17 expected failures, including both link-substitution cases and the resumed-execution lookup assertion after successful binding.
  • These are retrospective captures. The original red-first evidence discipline was missed; the response documents the late preservation checks and the fixture failure that had masked the resumption assertions. The replay does not claim to change that history.
  • No implementation-branch source or tests changed. Fresh verification of unchanged head 579bb3f46: 52,841 passed, 608 skipped, 26 xfailed. The scratch worktree was removed.
  • Complete logs, hashes, and the per-regression index are retained in the implementation worktree at .autoskillit/temp/rectify/red_gate_summary.md and .autoskillit/temp/rectify/red_evidence_response_5324_2026-10-26.md, with a canonical backup under the main repository's .autoskillit/temp/rectify/audit-red-evidence-5324-20261026/.
  • A formal /audit-impl rerun was not performed in this Codex session: its required join operation is unavailable on this backend. No formal GO verdict is claimed here.

@Trecek
Trecek added this pull request to the merge queue Oct 26, 2026
Merged via the queue into develop with commit 9d0c273 Oct 26, 2026
10 checks passed
@Trecek
Trecek deleted the impl-bind-containment-5324-20261025-230357 branch October 26, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant