Repository navigation
Fix plan-set admission from sibling worktrees - #5330
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recipe plan sets bind in the clone, while implementation and retry run in sibling worktrees. Admission previously derived containment from the consumer cwd, rejecting a valid clone authority before worker dispatch.
Retain the resolved root and issued digest for each successful recipe bind on the context-owned materializer. Admission requires a binding for the current execution, verifies the original authority path under that root, and compares the verified digest with the issued digest. Audit inputs retain invocation-cwd containment.
Adds production bind/renew through real sibling-worktree implement and retry regression coverage, plus provenance rejection, link substitution, renewal, same-context reinstall, and separate audit-root checks. Documents the process-local lifetime and trust assumptions.
Validation:
pre-commit run --all-files: PASS.test_check/task test-local-gatewith conservative filtering: 52,841 passed, 608 skipped, 26 xfailed.Fixes #5324.
Audit evidence follow-up (R-028):
940f8fb79with final test files from579bb3f46using the unchanged configuredtask test-local-gate. The complete replay retained 17 expected failures, including both link-substitution cases and the resumed-execution lookup assertion after successful binding.579bb3f46: 52,841 passed, 608 skipped, 26 xfailed. The scratch worktree was removed..autoskillit/temp/rectify/red_gate_summary.mdand.autoskillit/temp/rectify/red_evidence_response_5324_2026-10-26.md, with a canonical backup under the main repository's.autoskillit/temp/rectify/audit-red-evidence-5324-20261026/./audit-implrerun was not performed in this Codex session: its required join operation is unavailable on this backend. No formal GO verdict is claimed here.