Repository navigation
Conversation
Trecek
enabled auto-merge
October 25, 2026 23:00
Trecek
deleted the
impl-hosted-review-receipt-single-writer-20261025-implementation
branch
October 25, 2026 23:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review publisher could overwrite or retire a server-written GitHub receipt, causing an already-posted review to fail canonical ledger verification. Keep the receipt server-owned and publish a separate GitHub binding marker tied to its operation and publication generation.
Stage and sync publication files before changing payloads, invalidate old commit markers first, and restore markers only after payload recovery. Resolve-review validates the binding before ingesting pre-built context, and receipt verification now reports specific rejection reasons.
Validation:
test_checkgate (task test-local-gate): 42,301 passed, 599 skipped, 26 expected failures.pre-commit run --all-files: passed.Addresses #5317. Hosted commissioning remains an operational follow-up after merge.
Audit follow-up (
15654dda3): added the missingunexpected_errorregression using a valid request and receipt with an injected ledger-verificationRuntimeError, and moved both new production-symbol imports into their test functions. These address all three reported findings without production code changes. The configured gate and pre-commit checks pass; a fresh formal audit and evidence publication remain pending.