Skip to content

fix: preserve server review receipts with publisher-owned bindings - #5321

Merged
Trecek merged 21 commits into
developfrom
impl-hosted-review-receipt-single-writer-20261025-implementation
Oct 25, 2026
Merged

Trecek merged 21 commits into
developfrom
impl-hosted-review-receipt-single-writer-20261025-implementation

Conversation

@Trecek

@Trecek Trecek commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

The review publisher could overwrite or retire a server-written GitHub receipt, causing an already-posted review to fail canonical ledger verification. Keep the receipt server-owned and publish a separate GitHub binding marker tied to its operation and publication generation.

Stage and sync publication files before changing payloads, invalidate old commit markers first, and restore markers only after payload recovery. Resolve-review validates the binding before ingesting pre-built context, and receipt verification now reports specific rejection reasons.

Validation:

  • Configured test_check gate (task test-local-gate): 42,301 passed, 599 skipped, 26 expected failures.
  • pre-commit run --all-files: passed.
  • Regression coverage uses the real poster and isolated ledger, including replay, reconciliation, receipt tampering, mixed generations, and publication/rollback sync failures.

Addresses #5317. Hosted commissioning remains an operational follow-up after merge.

Audit follow-up (15654dda3): added the missing unexpected_error regression using a valid request and receipt with an injected ledger-verification RuntimeError, and moved both new production-symbol imports into their test functions. These address all three reported findings without production code changes. The configured gate and pre-commit checks pass; a fresh formal audit and evidence publication remain pending.

@Trecek
Trecek enabled auto-merge October 25, 2026 23:00
@Trecek
Trecek added this pull request to the merge queue Oct 25, 2026
Merged via the queue into develop with commit 677f81a Oct 25, 2026
10 checks passed
@Trecek
Trecek deleted the impl-hosted-review-receipt-single-writer-20261025-implementation branch October 25, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant