Repository navigation
test: make source guard inventories independent of line numbers - #5300
Merged
Merged
Conversation
Trecek
force-pushed
the
impl-canonical-json-site-identity-20261022
branch
from
October 22, 2026 21:16
7a0c456 to
01086c4
Compare
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harmless line shifts break the canonical JSON consumer registry, while its per-file comparison can let a valid consumer hide a missing sibling. These guards now identify sites by qualified scope and compare exact call counts.
_LEGACY_JSON_WRITE_COUNTSso initial registration does not attempt to read the old set as an integer map. The checker is unchanged.The work is split into one commit per plan part. Part A is isolated in
6f1f17beafor the planned integration into #5255; the remaining commits are the separately authorized follow-ups. Production code is unchanged.Validation:
pre-commit run --all-filesand the configuredtask test-local-gatepassed for every part. The final gate reported 52,148 passed, 614 skipped, and 29 expected failures. Pre-implementation baseline/red runs were not performed.Fixes #5295.