Skip to content

fix: publish own-author reviews as disclosed comments - #5298

Merged
Trecek merged 14 commits into
developfrom
impl-own-author-review-20261021
Oct 22, 2026
Merged

Trecek merged 14 commits into
developfrom
impl-own-author-review-20261021

Conversation

@Trecek

@Trecek Trecek commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

When the authenticated reviewer is the pull request's author, requested APPROVE and REQUEST_CHANGES reviews now publish one complete COMMENT batch with an explicit disclosure. Receipts retain both requested and effective events; third-party review events keep their existing behavior. The skill verdict and gate remain independent of GitHub's formal review state.

Choose the effective event from preflight identities and validate its body before creating ledger state. Remove the reactive self-review 422 transformation, retain bounded GitHub error details, ground the fake in captured API responses, and replace vacuous skill-family guards with a pattern coverage check.

Validation:

  • Configured test_check gate (task test-local-gate, conservative filtering): 32,608 passed, 276 skipped, 15 expected failures.
  • pre-commit run --all-files: passed.
  • Mutation check: sending the original event again fails exactly the own-author APPROVE, REQUEST_CHANGES, and author anchor-retry regressions; 32,605 other selected tests passed. Correct implementation restored before the green gate.

Existing terminal operations remain preserved and require a new head SHA or logical iteration to publish again. Anchor-422 response handling remains the separate follow-up described in the plan.

Fixes #5296.

@Trecek
Trecek added this pull request to the merge queue Oct 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 22, 2026
@Trecek
Trecek force-pushed the impl-own-author-review-20261021 branch from 76975a8 to 3e0d6f1 Compare October 22, 2026 19:40
@Trecek
Trecek added this pull request to the merge queue Oct 22, 2026
Merged via the queue into develop with commit 97e9ca8 Oct 22, 2026
11 checks passed
@Trecek
Trecek deleted the impl-own-author-review-20261021 branch October 22, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant