feat: support Minecraft 26.3 and fix selection geometry - #68
Merged
Merged
Conversation
- Bump paper-api to 26.3.build.41-alpha and spigot-api to 26.3-R0.1-SNAPSHOT. - Bump PacketEvents to 2.14.0, the first release that ships the 26.3 protocol. - Pin Adventure 5.2.0 in the Paper profile. Paper 26.3 builds against Adventure 5.2.0 while PacketEvents still declares 4.26.1 before paper-api, so mediation previously failed compilation on net.kyori.adventure.text.object.ObjectContentsLike. Align the shaded Adventure of the Spigot profile with PacketEvents at 4.26.1. - Build on JDK 25 in CI, because the 26.3 APIs are Java 25 class files. The artifact keeps Java 17 bytecode, so the Paper 1.19.4+ and Spigot 1.20+ ranges are unchanged. - Ship PacketEvents 2.14.0 in the Mineflayer harness and document the 26.3 support range and build JDK requirement in both README languages.
twme-ai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade WorldEditDisplay for Minecraft 26.3 and fix the displaced selection lines/fill faces shown with vanilla 26.3 and Improved Transparency.
79f954cuntil the library publishes a release.Cause, not a changed vanilla transform
I decompiled Mojang's official 26.2 and 26.3 client jars and compared
DisplayRenderer$TextDisplayRenderer. The Text Display transform order and one-space background quad coordinates are unchanged. Minecraft 26.3 changes the text-background shader path and Improved Transparency rendering, but the selection displacement is a geometry error in TextDisplayShapes. The shader/transparency change may make it more visible; that causal link has not been proven.The concrete compatibility change is JOML: Mojang's 26.2 version manifest uses 1.10.8, whereas its 26.3 manifest uses 1.10.9. JOML 1.10.9 fixed
Quaternion.lookAlong(). TextDisplayShapes relied on its old result when constructing line and face rotations. On the new runtime, some quaternions mirror the background away from the requested endpoints; double-sided lines can extend a full edge length outside the selection. TextDisplayShapes PR #39 now constructs the X/Y/Z basis explicitly so the same geometry is produced on both JOML versions.Verification
mvn -B -q clean package(Paper) andmvn -B -q clean package -P spigot: 51 tests pass in each profile../integration/mineflayer/run-e2e.shon Paper 1.21.11 / JOML 1.10.8: full CUI/share/retained-renderer flow passes, and all 150 line/fill Text Display backgrounds fit the selection.textdisplayshape-packet:79f954cfrom the original repository.The 26.3 test uses a bridged client only because Mineflayer does not yet speak 26.3. This verifies the 26.3 server's packets and transformations, not a vanilla 26.3 screenshot with Improved Transparency enabled. A human visual check with that setting remains useful before release.
Merge note
This PR depends on TextDisplayShapes PR #39. Once its fix is released, replace the temporary JitPack commit pin with that release coordinate.