feat: support Minecraft 26.3 and fix Text Display orientation - #39
Merged
Merged
Conversation
- Bump paper-api to 26.3.build.41-alpha and spigot-api to 26.3-R0.1-SNAPSHOT for the paper, spigot, and packet modules. - Bump PacketEvents to 2.14.0, the first release that ships the 26.3 protocol, in the packet module and the integration fixture. - Pin Adventure 5.2.0 on the Paper compile classpaths. PacketEvents declares Adventure 4.26.1 before paper-api, so mediation previously produced a mixed 4.x/5.x classpath and compilation failed on net.kyori.adventure.text.object.ObjectContentsLike. - Build on JDK 25 in CI and JitPack, because the 26.3 APIs are Java 25 class files that javac 21 cannot read. The published modules keep Java 17 bytecode, so the Text Display floor is unchanged. - Ship PacketEvents 2.14.0 in the Mineflayer harness and document the 26.3 dependency matrix in the README.
twme-ai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade TextDisplayShapes for Minecraft 26.3 and fix line/face orientation across JOML versions.
Quaternionf.lookAlong(...).conjugate()with a quaternion constructed from the explicit X/Y/Z basis inTextDisplayUtil. This covers lines, parallelograms, and triangles.Root cause
Mojang's 26.2 version manifest declares JOML 1.10.8; its 26.3 manifest declares 1.10.9. JOML 1.10.9 explicitly fixes
Quaternion.lookAlong(). The former orientation calculation produced different quaternions under those versions, mirroring a Text Display background away from its supplied vertices in 26.3. Reversing a double-sided line could extend it by an additional full line length. Building the orthonormal basis directly removes that version-dependent behavior.The vanilla 26.2 and 26.3
DisplayRenderer$TextDisplayRendererbytecode retains the same Text Display transformation order and background quad dimensions. Minecraft 26.3 changes the background shader path and the Improved Transparency algorithm, but those are not the coordinate error itself.Verification
mvn -B -q clean install: all modules and API/packet tests pass.Related
The WorldEditDisplay PR currently consumes this commit through JitPack until TextDisplayShapes publishes a new release. Please merge/release this fix before replacing that temporary pin with a release version. No vanilla 26.3 visual screenshot comparison has been automated; the packet geometry is verified.