Skip to content

fix(passkey): Prevent Sentry exception on iOS passkey cancellation #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

fix(passkey): Prevent Sentry exception on iOS passkey cancellation #2535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hooks/useUser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ const useUser = (): UseUserReturn => {
? 'User not found, please sign up'
: error?.message || 'Network request timed out';

if (error?.name === 'NotAllowedError') {
if (error?.name === 'NotAllowedError' || isPasskeyPromptError(error)) {
errorMessage = 'User cancelled login';
Sentry.captureMessage(errorMessage, {
level: 'warning',
Expand Down
1 change: 1 addition & 0 deletions lib/utils/__tests__/passkey-credentials.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ describe('mergeCredentialIds', () => {
describe('isPasskeyPromptError', () => {
it.each([
['iOS cancellation', { message: 'The user cancelled the request.' }],
['Turnkey UserCancelled', { error: 'UserCancelled', message: 'The user cancelled the request.' }],
['Android Credential Manager', { message: '[16] Cancelled by user.' }],
['WebAuthn DOMException', { name: 'NotAllowedError', message: 'not allowed' }],
['aborted ceremony', { name: 'AbortError', message: 'aborted' }],
Expand Down
Loading