fix(passkey): Prevent Sentry exception on iOS passkey cancellation - #2535
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where iOS passkey cancellations, when wrapped by the Turnkey SDK, were incorrectly reported as exceptions in Sentry instead of being handled as warnings.
Changes Made:
hooks/useUser.tsto includeisPasskeyPromptError(error)in the condition for identifying user cancellations. This ensures that Turnkey's{ error: 'UserCancelled', message: 'The user cancelled the request.' }shape is correctly caught and routed to the warning path.lib/utils/__tests__/passkey-credentials.test.tsto explicitly cover the TurnkeyUserCancellederror shape, confirming thatisPasskeyPromptErrorcorrectly identifies it.Fixes SOLID-101
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.