Skip to content

Budget Web bundle bytes per source package #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kiftio wants to merge 1 commit into from
+26 −0
Draft

Budget Web bundle bytes per source package #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .ci/bundle-size-budgets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,24 @@
"measurement": "bundle",
"softKiB": 40,
"hardKiB": 50
},
"checkoutKit": {
"measurement": "bundlePackage",
"package": "@shopify/checkout-kit",
"softKiB": 18,
"hardKiB": 24
},
"protocol": {
"measurement": "bundlePackage",
"package": "@shopify/checkout-kit-protocol",
"softKiB": 16,
"hardKiB": 20
},
"telemetry": {
"measurement": "bundlePackage",
"package": "@shopify/checkout-kit-telemetry",
"softKiB": 5,
"hardKiB": 8
}
},
"react-native": {
Expand Down
8 changes: 8 additions & 0 deletions .ci/bundle-size-budgets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ Budget one package with `"measurement": "bundlePackage"` and its npm name:
}
```

Configured Web package budgets (uncompressed, minified bytes):

| Package | Soft limit | Hard limit |
| --- | --- | --- |
| `@shopify/checkout-kit` | 18 KiB | 24 KiB |
| `@shopify/checkout-kit-protocol` | 16 KiB | 20 KiB |
| `@shopify/checkout-kit-telemetry` | 5 KiB | 8 KiB |

A budgeted package that no longer contributes bytes reports a missing
measurement. Remove or rename its budget in the same change. Accepting a
per-package breach records that package, so the acceptance cannot satisfy
Expand Down
Loading