Repository navigation
Conversation
kiftio
added this pull request to stack #945
October 8, 2026 13:26
kiftio
force-pushed
the
dk/web-package-bundle-budgets
branch
2 times, most recently
from
October 8, 2026 14:23
1c98f27 to
73ed8b4
Compare
kiftio
removed this pull request from stack #945
October 8, 2026 14:29
kiftio
added this pull request to stack #959
October 8, 2026 14:29
kiftio
force-pushed
the
dk/web-package-bundle-budgets
branch
from
October 8, 2026 15:02
73ed8b4 to
37ddb1c
Compare
kiftio
force-pushed
the
dk/web-package-bundle-budgets
branch
2 times, most recently
from
October 8, 2026 16:22
d62ce74 to
61b214f
Compare
Add soft/hard budgets for the code each package contributes to the shipped Web JavaScript, measured with `bundlePackage`: - @shopify/checkout-kit: 18 / 24 KiB (currently 15.9 KiB) - @shopify/checkout-kit-protocol: 16 / 20 KiB (currently 14.3 KiB) - @shopify/checkout-kit-telemetry: 5 / 8 KiB (currently 4.2 KiB) Requires the `bundlePackage` measurement on the default branch; until then Size budgets rejects this budget file.
kiftio
force-pushed
the
dk/web-package-bundle-budgets
branch
from
October 8, 2026 19:25
61b214f to
25648f4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Adds per-package soft/hard budgets for the code each package contributes to the shipped Web JavaScript, using the
bundlePackagemeasurement from #952. Values are minified, uncompressed bytes:@shopify/checkout-kit@shopify/checkout-kit-protocol@shopify/checkout-kit-telemetryThe total Web JavaScript budget (40 / 50 KiB, set in #952) still applies. Bundler glue (about 830 B) counts only toward the total.
Note
Size budgets fails on this PR until #952 is on
main, because the default branch's policy does not yet knowbundlePackage. Merge #952 first, then re-run Package Size here.How to test
withinfor this stack:checkoutKit16,256 B,protocol14,690 B,telemetry4,272 B, total 36,050 B.