Skip to content

Ignore duplicate Swift checkout presentations - #942

Merged
markmur merged 1 commit into
mainfrom
swift-checkout-presentation-guard
Oct 8, 2026
Merged

markmur merged 1 commit into
mainfrom
swift-checkout-presentation-guard

Conversation

@markmur

@markmur markmur commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Repeated Swift present() calls can stack checkout controllers or attempt another presentation during dismissal. Return the existing checkout in the presenter’s modal hierarchy, preserving its original URL and delegate.

Both the public and accelerated-checkout entry points use the guard; independent presentation hierarchies remain independent.

Stack

@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Oct 8, 2026
@markmur
markmur added this pull request to stack #943 October 8, 2026 11:06
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Bundle Size Budgets

Budget Size Limits Result
— — — ➖ No configured budgets affected

Bundle and package size

Web bundle sizes cover shipped runtime JavaScript. Package sizes cover the full published archive, including any source maps, declarations, and documentation it contains.

Platform Measurement Compression Base Head Delta
- - - - - -
How sizes are measured

Measured from the PR base SHA and PR head SHA. Web bundle rows sum shipped .js, .mjs, and .cjs files under dist/, excluding source maps and declarations. The gzip bundle size sums files compressed individually with gzip -n -9. npm package sizes are gzip-compressed .tgz archives; Android AAR sizes are ZIP archives. Package sizes are not final app binary sizes.

@bitrise

bitrise Bot commented Oct 8, 2026

Copy link
Copy Markdown

Bitrise builds

E2E · iOS CI

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
Swift Install with Tophat

Checkout Kit E2E results

Status Tags Target Platform OS version tag Device
✅ launch, checkout-presentation, checkout-completion, buyer-identity, preload swift ios latest iPhone 15
iOS 27 Beta

@markmur
markmur removed this pull request from stack #943 October 8, 2026 11:35
@markmur
markmur added this pull request to stack #947 October 8, 2026 11:36
@markmur
markmur merged commit dc5b744 into main Oct 8, 2026
48 checks passed
@markmur
markmur deleted the swift-checkout-presentation-guard branch October 8, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants