Skip to content

React Native: isolate presentation subscription cleanup - #920

Open
markmur wants to merge 2 commits into
rn-checkout-snapshot-decodingfrom
rn-checkout-subscription-safety
Open

markmur wants to merge 2 commits into
rn-checkout-snapshot-decodingfrom
rn-checkout-subscription-safety

Conversation

@markmur

@markmur markmur commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

A terminal callback can open another checkout or throw before its subscription is released. Release the originating subscription before invoking consumer callbacks, ignore queued events after removal, and clean up when native presentation throws. This preparation preserves the current public API and native dependency versions.

Stack

@markmur
markmur requested a review from a team as a code owner October 6, 2026 13:33
@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Oct 6, 2026
@markmur
markmur added this pull request to stack #922 October 6, 2026 13:33
@markmur markmur changed the title Isolate React Native presentation subscriptions during cleanup React Native: isolate presentation subscription cleanup Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 91%
91.21% (374/410) 87% (221/254) 100% (93/93)

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Bundle Size Budgets

Budget Size Limits Result
React Native npm package (gzip) 120.49 KiB (+445 B) 130 KiB soft / 150 KiB hard ✅ Within budget

Bundle and package size

Web bundle sizes cover shipped runtime JavaScript. Package sizes cover the full published archive, including any source maps, declarations, and documentation it contains.

Platform Measurement Compression Base Head Delta
React Native npm package (.tgz) gzip 120.1 KiB 120.5 KiB +445 B
React Native package files (uncompressed)

These are uncompressed file sizes; they do not sum to the compressed package size above.

File Base Head Delta
node_modules/@shopify/checkout-kit-protocol/src/generated/Models.ts 108.7 KiB 108.7 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/Models.d.ts 73.1 KiB 73.1 KiB 0 B
android/src/main/java/com/shopify/reactnative/checkoutkit/ShopifyCheckoutKitModule.java 16.2 KiB 16.2 KiB 0 B
ios/ShopifyCheckoutKit.swift 16.1 KiB 16.1 KiB 0 B
ios/AcceleratedCheckoutButtons.swift 14.1 KiB 14.1 KiB 0 B
src/index.ts 12.7 KiB 13.0 KiB +386 B
src/components/AcceleratedCheckoutButtons.tsx 13.0 KiB 13.0 KiB 0 B
lib/commonjs/index.js 12.4 KiB 12.7 KiB +346 B
lib/commonjs/components/AcceleratedCheckoutButtons.js 11.4 KiB 11.4 KiB 0 B
src/index.d.ts 11.3 KiB 11.3 KiB 0 B
lib/module/index.js 10.4 KiB 10.7 KiB +346 B
lib/commonjs/components/AcceleratedCheckoutButtons.js.map 10.4 KiB 10.4 KiB 0 B
lib/module/components/AcceleratedCheckoutButtons.js 10.2 KiB 10.2 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolNotifications.ts 9.5 KiB 9.5 KiB 0 B
lib/module/components/AcceleratedCheckoutButtons.js.map 9.1 KiB 9.1 KiB 0 B
lib/module/index.js.map 8.1 KiB 8.4 KiB +309 B
lib/commonjs/index.js.map 7.9 KiB 8.2 KiB +314 B
src/present-dispatcher.ts 8.0 KiB 8.2 KiB +205 B
node_modules/@shopify/checkout-kit-protocol/src/protocol_codec_runtime.ts 7.9 KiB 7.9 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolRenameMap.ts 7.8 KiB 7.8 KiB 0 B
…and 117 smaller files
How sizes are measured

Measured from the PR base SHA and PR head SHA. Web bundle rows sum shipped .js, .mjs, and .cjs files under dist/, excluding source maps and declarations. The gzip bundle size sums files compressed individually with gzip -n -9. npm package sizes are gzip-compressed .tgz archives; Android AAR sizes are ZIP archives. Package sizes are not final app binary sizes.

@markmur markmur self-assigned this Oct 6, 2026
@markmur
markmur force-pushed the rn-checkout-subscription-safety branch from 69de22b to 6223321 Compare October 6, 2026 13:38
@bitrise

bitrise Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Bitrise builds

E2E · iOS CI

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
React Native Install with Tophat

Checkout Kit E2E results

Status Tags Target Platform OS version tag Device
✅ launch, checkout-presentation, checkout-completion, buyer-identity react-native ios latest iPhone 15
iOS 27 Beta
✅ launch, checkout-presentation, checkout-completion, buyer-identity react-native android latest Google Pixel 9
Android 17.0

@markmur
markmur force-pushed the rn-checkout-subscription-safety branch 2 times, most recently from 8d2bb95 to edae6b1 Compare October 7, 2026 09:43
@markmur
markmur force-pushed the rn-checkout-subscription-safety branch from edae6b1 to f5d1aaf Compare October 8, 2026 10:38
@markmur
markmur removed this pull request from stack #922 October 8, 2026 11:06
@markmur
markmur force-pushed the rn-checkout-subscription-safety branch from f1f19bd to 8761655 Compare October 8, 2026 11:06
@markmur
markmur added this pull request to stack #943 October 8, 2026 11:06
@markmur
markmur removed this pull request from stack #943 October 8, 2026 11:35
@markmur
markmur force-pushed the rn-checkout-subscription-safety branch from 8761655 to 546117c Compare October 8, 2026 11:36
@markmur
markmur added this pull request to stack #947 October 8, 2026 11:36
@markmur
markmur force-pushed the rn-checkout-subscription-safety branch from 546117c to b1eedb8 Compare October 8, 2026 11:55
@markmur
markmur force-pushed the rn-checkout-subscription-safety branch from b1eedb8 to 19cb873 Compare October 8, 2026 12:19
@markmur
markmur force-pushed the rn-checkout-subscription-safety branch from b1eedb8 to 19cb873 Compare October 8, 2026 12:19

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants