Skip to content

feat(composer): allow specify run order #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Frzk merged 2 commits into from
Nov 12, 2026
Merged

feat(composer): allow specify run order #635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87c0cca
feat(composer): allow specify run order
Frzk Nov 12, 2026
8e518b8
chore: add comment
Frzk Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions bin/compile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,11 +495,24 @@ if [ -n "$PHP_FPM_INCLUDES" ] ; then
done
fi

if [ "$PHP_BUILDPACK_NO_NODE" != "true" ] ; then
install_node_deps "$BUILD_DIR"

# By default, we run npm first, and then Composer.

@matthieu526-scalingo matthieu526-scalingo Nov 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: can you specify in the comment why it is useful? (eg which framework, like you did in the description)

@Frzk Frzk Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 8e518b8

# If PHP_BUILDPACK_RUN_COMPOSER_FIRST is set to "true", we run Composer first
# and then npm.
# This is especially useful for frameworks such a symfony-ux that require
# Composer to run before npm.
if [[ "${PHP_BUILDPACK_RUN_COMPOSER_FIRST:-}" = 'true' ]]; then
install_composer_deps "${BUILD_DIR}" "${CACHE_DIR}" "${ENV_DIR}"
fi

if [[ "${PHP_BUILDPACK_NO_NODE:-}" != "true" ]] ; then
install_node_deps "${BUILD_DIR}"
fi

if [[ "${PHP_BUILDPACK_RUN_COMPOSER_FIRST:-}" != 'true' ]]; then
install_composer_deps "${BUILD_DIR}" "${CACHE_DIR}" "${ENV_DIR}"
fi

install_composer_deps "${BUILD_DIR}" "${CACHE_DIR}" "${ENV_DIR}"

# Detect PHP framework
# Set FRAMEWORK if not set in environment by user
Expand Down