Repository navigation
feat(composer): allow specify run order - #635
Merged
Merged
Conversation
Introduces a new environment variable (`PHP_BUILDPACK_RUN_COMPOSER_FIRST`), which, when set to `true`, makes the buildpack run Composer BEFORE npm. This is useful when running frameworks such as symfony-ux.
Frzk
requested review from
a team,
EtienneM,
briceamen and
matthieu526-scalingo
and removed request for
a team
November 12, 2026 11:30
matthieu526-scalingo
previously approved these changes
Nov 12, 2026
| if [ "$PHP_BUILDPACK_NO_NODE" != "true" ] ; then | ||
| install_node_deps "$BUILD_DIR" | ||
|
|
||
| # By default, we run npm first, and then Composer. |
Contributor
There was a problem hiding this comment.
nitpick: can you specify in the comment why it is useful? (eg which framework, like you did in the description)
As suggested by @matthieu526-scalingo in PR review
matthieu526-scalingo
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new environment variable named
PHP_BUILDPACK_RUN_COMPOSER_FIRST, which, when set totrue, makes the buildpack run Composer BEFORE npm.This is useful when running frameworks such as symfony-ux.
Supersedes #494